New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop thumb type from (most) movies, shows, seasons + sets + fixes #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…being checked periodically, as the hash from the database was never returned.
… size of local art to classify 'thumb' into the correct types (poster/banner)
…es in the Choose Art dialog
…choosing poster or banner
…er based on aspect ratio
…son.thumb, making tvshow.poster/banner and season.poster/banner also available. Container.TVShowThumb/SeasonThumb are still available for backward compatibility
…oose art on the video info dialog
ghost
pushed a commit
that referenced
this pull request
Oct 31, 2012
Drop thumb type from (most) movies, shows, seasons + sets + fixes
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main thing that this PR handles is dropping the "thumb" art type from movies, shows, seasons and sets. Essentially we demand a poster for movies and sets, and a banner or poster for shows and seasons.
It works as follows:
There's update code in place to move all the existing thumbs to poster/banner (both Eden + pre-Frodo).
Finally, thumb is always available as a fallback for skinners (it falls "forward" to poster then banner if a thumb type isn't there).
In addition, this moves to support banner and poster (and fanart) for seasons.
Finally, we have a bunch of fixes for the "Season Thumb" and "Movie set thumb/fanart" context menu items, which have been replaced with a "Choose art" item, which throws up the Choose Art dialog.