Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] added missing dependency #17016

Merged
merged 1 commit into from
Apr 6, 2020
Merged

[docs] added missing dependency #17016

merged 1 commit into from
Apr 6, 2020

Conversation

DaVukovic
Copy link
Member

Description

libunistring-devel is missing as a dependency for Fedora.

Motivation and Context

Can't build current Kodi master with only libunistring being installed.

How Has This Been Tested?

Tested on Fedora 30 and 31.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@DaVukovic DaVukovic added this to the Matrix 19.0-alpha 1 milestone Dec 8, 2019
@phunkyfish phunkyfish added the PR Cleanup: Needs Review This PR is good and ready for a review. Someone please review. label Mar 9, 2020
@phunkyfish
Copy link
Contributor

phunkyfish commented Mar 9, 2020

@lrusak you also built on fedora, maybe you could review?

@fuzzard fuzzard merged commit 5899985 into xbmc:master Apr 6, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Apr 6, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Depends Platform: Linux PR Cleanup: Needs Review This PR is good and ready for a review. Someone please review. Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants