[videoplayer] Fix GetItemsToScan scan in sub-directories

[bahusoid]

GetItemsToScan currently always scans for subtitles in additional directories. It should scan for requested extensions instead.

Fixes #17014 (technical details here). Verified on this win32 test build

Also fixes scan for external audio tracks (ScanForExternalAudio) and .sup subtitles (ScanForExternalDemuxSub) in sub-directories for video

[jjd-uk]

I can't help reviewing this, but I note you seem to have done this blind and have not tested the fix for yourself. If you've not been able to generate your own test build we can kick one off for you if you let us know what OS you need the build for (as long as it's not Linux).

[jjd-uk]

Ok I've used our Jenkins CI system to kick off a build, see https://jenkins.kodi.tv/view/Helpers/job/BuildMulti-PR-Manually/310/ for status, once it reports successful build (normally 30min to complete) it will upload to http://mirrors.kodi.tv/test-builds/windows/ and it will have PR number in filename, but it may take up to another 30 min for to appear on your local mirror.

[bahusoid]

@jjd-uk Thanks

I confirm it really fixes #17014 - chapters are back in test build.

It also would be good to fix it in Leia too. Seems I need to create a backport pr for Leia branch. Am I right?

[jjd-uk]

Let's wait first for someone to review what you've done, I'm not one of the core devs so can't do that.

[arnova]

Looks sane to me, @ace20022 ?

[ace20022]

Looks sane to me, @ace20022 ?

to me too ;)

[jjd-uk]

Jenkins build this please

[jjd-uk]

@arnova would you mind hitting merge if this is ok with you as @ace20022 has approved, and I assume the Win UWP build failure is down to the known python 3 issues with UWP.. As I'm not a C++ guy not comfortable doing it myself.

[bahusoid]

@arnova Yeah can you please merge it and add backport related labels (backport pr - #17098). Thank you!

[jjd-uk]

As Win UWP build issues are now fixed in master I'll do another...

Jenkins build this please