Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[videodb] use UpdateUniqueIDs() instead of AddUniqueIDs() in VideoDatabase::SetDetailsForMovie() #17092

Merged

Conversation

Montellese
Copy link
Member

Description

This changes CVideoDatabase::SetDetailsForMovie() to use UpdateUniqueIDs() instead of AddUniqueIDs() like all other CVideoDatabase::SetDetailsForXXX() methods. Right now it's not possible to remove unique IDs from movies.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Montellese Montellese added Type: Fix non-breaking change which fixes an issue Component: Database v19 Matrix labels Dec 28, 2019
@Montellese Montellese added this to the Matrix 19.0-alpha 1 milestone Dec 28, 2019
@Montellese Montellese added this to In progress in General (roadmap) via automation Dec 28, 2019
@Montellese
Copy link
Member Author

@phate89 you added this logic but only used AddUniqueIDs() for movies. Do you remember if there was a specific reason for this?

@phate89
Copy link
Contributor

phate89 commented Jan 1, 2020

I sincerely don't remember why I used that different one there. Probably I did it this way just because I structured the code like for ratings and in ratings they were like this.
I'm a little bit rusty on this code but right now I can't think of a good reason not to use UpdateUniqueIDs..

@Montellese Montellese merged commit bcc95a7 into xbmc:master Jan 1, 2020
General (roadmap) automation moved this from In progress to Done Jan 1, 2020
@Montellese Montellese deleted the bugfix/videodb_movie_update_uniqueid branch January 1, 2020 21:30
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jan 21, 2020
…date_uniqueid

[videodb] use UpdateUniqueIDs() instead of AddUniqueIDs() in VideoDatabase::SetDetailsForMovie()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Database Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants