Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[video] fix "Browse" button in CGUIDialogVideoInfo for tvshows #17095

Merged
merged 1 commit into from Dec 31, 2019

Conversation

Montellese
Copy link
Member

Description

In my media import work I got a report that the "Browse" button in the video info dialog is not working for imported tvshows. This fixes the issue. The same issue can currently happen if a user sets up a tvshow using NFOs which cannot be looked up using a scraper. I'm guessing this code exists since before we explicitely tag media items with their type.

On a side note I noticed that the "Browse" button is very confusing when the user opens the video info dialog on a tvshow season because he actually ends up in the video info dialog for the tvshow and not the season. So using the "Browse" button there brings you back to the list of seasons and not to the list of episodes of the selected season.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Montellese Montellese added Type: Fix non-breaking change which fixes an issue Component: Video v19 Matrix labels Dec 28, 2019
@Montellese Montellese added this to the Matrix 19.0-alpha 1 milestone Dec 28, 2019
@Montellese Montellese added this to In progress in General (roadmap) via automation Dec 28, 2019
@Montellese Montellese merged commit 15dcf22 into xbmc:master Dec 31, 2019
General (roadmap) automation moved this from In progress to Done Dec 31, 2019
@Montellese Montellese deleted the bugfix/browse_tvshow branch December 31, 2019 23:58
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jan 21, 2020
[video] fix "Browse" button in CGUIDialogVideoInfo for tvshows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant