[PVR] Guide window: Goto 'now' on system resume from sleep. #17108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Improvement
|
I noticed this myself, although not on suspend/resume just when the TV is switched on (I don’t ever suspend my devices), it just takes the display out of dimming and if on the guide need to leave and re-enter it to refresh. I wonder if this will also work for my use case when it’s running and just woken via CEC. |
I don't think power manager provides something for this case: class IPowerEventsCallback
{
public:
virtual ~IPowerEventsCallback() = default;
virtual void OnSleep() = 0;
virtual void OnWake() = 0;
virtual void OnLowBattery() = 0;
}; |
|
Ya, I would need to soak test it. Unless CEC mimics a wake. Not to hard to test for. |
|
Jenkins WIN-UWP-64 error is unrelated. |
|
It looks like CEC can call wake when deactivating the screen saver so this will most likely work for my use case too 😉 Nice |
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Jan 21, 2020
[PVR] Guide window: Goto 'now' on system resume from sleep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was requested several times in the forum.
Runtime-tested on latest Kodi master, macOS.
@Jalle19 @phunkyfish Got time for a quick code review?
Please note that this currently will not work on Android, due to incomplete power management implementation: https://github.com/xbmc/xbmc/blob/master/xbmc/platform/android/powermanagement/AndroidPowerSyscall.cpp#L30 is missing support to signal suspend/resume/... to the provided callback instance. Maybe @peak3d can take a look?