New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport] [scraper] Pass JSON serialized path settings to python scrapers #17112
[backport] [scraper] Pass JSON serialized path settings to python scrapers #17112
Conversation
056bc08
to
d4ffa2b
Compare
IMO this is ready to be merged into |
Sorry I have not been following this work. I'm sure it is all fine, but can someone just confirm the scope of the impact of this change. I assume Python scrapers only, is that correct? |
Ya, the functional change is limited to Python scrapers. There is also a structural change for subsettings, motivation detailed in the second paragraph of #17062 . |
Actually I think this would even work without refactoring where |
d4ffa2b
to
1571fa7
Compare
Yup that seems to work as well. @rmrector could you verify the functionality again with the reduced version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, a quick run works just fine. Thanks for slimming down the backport.
@DaveTBlake now it's really ready :-) |
Thanks for slimming this down @Montellese , always good to simplify backports if possible, glad that I was slow on the button. |
Description
This is a partial backport of #17062 and #17063.
Motivation and Context
It was requested by @romanvm and @rmrector.
Types of change
Checklist: