[PVR] EPG grid container: Make CGUIEPGGridContainer::GoToEnd consistent with CGUIEPGGridContainer::GoToBegin behavior #17114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt with CGUIEPGGridContainer::GoToBegin behavior.
ksooo
added
Type: Cleanup
phunkyfish
approved these changes
Jan 1, 2020
|
Jenkins WIN-UWP-64 error is unrelated. |
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Jan 21, 2020
[PVR] EPG grid container: Make CGUIEPGGridContainer::GoToEnd consistent with CGUIEPGGridContainer::GoToBegin behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoToBeginalways jumps to the first page of the EPG grid, regardless of the selected channel.This PR makes
GoToEndbehave consistent withGoToBegin. Now, the former will always jump to the last grid page, regardless of the selected channel.Old
GoToEndbehavior was to jump to the beginning of the last EPG tag of the selected channel. Often you ended up at the start of final "gap" (which is no actual event) that fills the grid from end of last real event to grid end. For channels without EPG this means, that selecting "goto end" will do the same as "goto begin" which is pretty irritating, IMO.Runtime-tested on mackOS and ANdroid, latest Kodi master.
@phunkyfish for code review?