Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset playlist on new file playback #17123

Merged
merged 1 commit into from Jan 6, 2020
Merged

Conversation

a1rwulf
Copy link
Member

@a1rwulf a1rwulf commented Jan 3, 2020

Suggested fix from @FernetMenta for #16690
@arnova could you test this, I have no PVR setup and have some trouble to trigger your issue.
Thx.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@a1rwulf a1rwulf added Type: Fix non-breaking change which fixes an issue v19 Matrix labels Jan 3, 2020
@a1rwulf a1rwulf added this to the Matrix 19.0-alpha 1 milestone Jan 3, 2020
@arnova
Copy link
Member

arnova commented Jan 4, 2020

Yup, fixes the issue. Could you please create a backport PR for Leia as well?

@arnova
Copy link
Member

arnova commented Jan 5, 2020

@A1rWolf : Could you add a comment why this is required? Same for backport. Tia!

Fixes: xbmc#16690

Co-authored-by: Rainer Hochecker <fernetmenta@online.de>
@a1rwulf
Copy link
Member Author

a1rwulf commented Jan 6, 2020

@arnova Comment added in code and issue mentioned in commit message.

@arnova
Copy link
Member

arnova commented Jan 6, 2020

@a1rwulf : Thanks!

@arnova arnova merged commit dec57ca into xbmc:master Jan 6, 2020
@arnova
Copy link
Member

arnova commented Jan 6, 2020

UWP build error unrelated

Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants