Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Address regression due to recent PVR recordings change #17154

Merged
merged 1 commit into from Jan 8, 2020
Merged

[PVR] Address regression due to recent PVR recordings change #17154

merged 1 commit into from Jan 8, 2020

Conversation

djp952
Copy link
Contributor

@djp952 djp952 commented Jan 8, 2020

Description

This PR addresses a regression caused by PR 17140. Proper initialization of the CPVRRecording class' m_strFileNameAndPath member is bypassed if the Update() method is never called for that instance to reinitialize all member variables.

Motivation and Context

This regression was noted by @ksooo after the PR was merged to master branch, this is an oversight of the original PR testing in which I did not fully verify the state of all member variables before and after the change.

How Has This Been Tested?

Tested on recent Matrix nightly (Jan 8, ref 13b724e), Windows x64 Desktop.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@djp952 djp952 requested a review from ksooo as a code owner January 8, 2020 17:26
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ksooo ksooo added Component: PVR Type: Fix non-breaking change which fixes an issue v19 Matrix labels Jan 8, 2020
@ksooo ksooo added this to the Matrix 19.0-alpha 1 milestone Jan 8, 2020
@ksooo
Copy link
Member

ksooo commented Jan 8, 2020

WIN-32 and WIN-64 Jenkins error ([ FAILED ] TestWebServer.CanHeadFile) is unrelated.

@ksooo ksooo merged commit a6d6cbd into xbmc:master Jan 8, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jan 21, 2020
[PVR] Address regression due to recent PVR recordings change
@djp952 djp952 deleted the recordings-regression branch January 29, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants