Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows][depends] Fix missing algorithms in pycryptodome #17157

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

Paxxi
Copy link
Member

@Paxxi Paxxi commented Jan 9, 2020

Description

I missed a couple of algorithms when building pycryptodome, most importantly MD5

Motivation and Context

How Has This Been Tested?

Been tested by the user reporting it in #17143

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Essam311
Copy link

Essam311 commented Jan 9, 2020

Could you please post a test build for windows 64 to be sure that everything is working with the Netflix plugin?

@Paxxi
Copy link
Member Author

Paxxi commented Jan 9, 2020

@Essam311
Copy link

Essam311 commented Jan 9, 2020

Thank you, still getting an error message, here is the full debug log.

https://paste.kodi.tv/genaruheza.kodi

File "C:\Program Files\Kodi\system\python\lib\site-packages\Cryptodome\Cipher_init_.py", line 36, in
from Cryptodome.Cipher._mode_gcm import _create_gcm_cipher
File "C:\Program Files\Kodi\system\python\lib\site-packages\Cryptodome\Cipher_mode_gcm.py", line 51, in
from Cryptodome.Util import _cpu_features
File "C:\Program Files\Kodi\system\python\lib\site-packages\Cryptodome\Util_cpu_features.py", line 38, in
""")
File "C:\Program Files\Kodi\system\python\lib\site-packages\Cryptodome\Util_raw_api.py", line 299, in load_pycryptodome_raw_lib
raise OSError("Cannot load native module '%s': %s" % (name, ", ".join(attempts)))
OSError: Cannot load native module 'Cryptodome.Util._cpuid_c': Trying '_cpuid_c.cp37-win_amd64.pyd': [WinError 126] The specified module could not be found, Trying '_cpuid_c.pyd': [WinError 126] The specified module could not be found
-->End of Python script error report<--

@Essam311
Copy link

Essam311 commented Jan 9, 2020

This file was missing "_cpuid_c.cp37-win_amd64.pyd"

_cpuid_c.cp37-win_amd64.zip

I downloaded it from here

http://qpypi3.qpython.org/repository/1886388/pycryptodomex-3.9.4-cp37-cp37m-win_amd64.whl#1a02ea8425a8526ff1d37ce1c66cce9e

and placed it in

C:\Program Files\Kodi\system\Python\Lib\site-packages\Cryptodome\Util

and the problem of the error message solved, and the Netflix add-on worked. Thank you so much.

@CastagnaIT
Copy link
Collaborator

and the problem of the error message solved

solved for you, but the pyd is missing again

@Essam311
Copy link

Essam311 commented Jan 9, 2020

@CastagnaIT It looks it solved here.

Paxxi/pycryptodome@789d3c3

@Paxxi Please post a test build for windows 64 after the fixing for testing, thanks.

@Paxxi
Copy link
Member Author

Paxxi commented Jan 10, 2020

New test build here http://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20200110-b29f55b4-pycryptodome-x64.exe Now everything should be working I believe.

@Essam311
Copy link

@Paxxi Thank you so much, everything is working fine now.

@CastagnaIT
Copy link
Collaborator

yeah finally i don't go crazy doing nf tests anymore
thanks very much!

@Paxxi Paxxi merged commit 6e017a3 into xbmc:master Jan 10, 2020
@Paxxi Paxxi deleted the pycryptodome branch January 10, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants