Fix HEAD Content-Length #17159
Merged
Fix HEAD Content-Length #17159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Microhttpd added sanity checking for Content-Length in 0.9.68 see the cryptic release notes at https://git.gnunet.org/libmicrohttpd.git/tree/ChangeLog mentioning MHD_RF_INSANITY_HEADER_CONTENT_LENGTH
|
I had never seen all the balls in green :D This has to be merged as soon as possible 👍 |
Montellese
reviewed
Jan 20, 2020
| @@ -1303,5 +1303,11 @@ int CWebServer::AddHeader(struct MHD_Response *response, const std::string &name | |||
|
|
|||
| CLog::Log(LOGDEBUG, LOGWEBSERVER, "CWebServer[%hu] [OUT] %s: %s", m_port, name.c_str(), value.c_str()); | |||
|
|
|||
| #if MHD_VERSION >= 0x00096800 | |||
| if (name == "Content-Length") | |||
There was a problem hiding this comment.
You should have used MHD_HTTP_HEADER_CONTENT_LENGTH.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Jan 21, 2020
Fix HEAD Content-Length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Microhttpd added sanity checking for Content-Length in 0.9.68
see the cryptic release notes at
https://git.gnunet.org/libmicrohttpd.git/tree/ChangeLog mentioning
MHD_RF_INSANITY_HEADER_CONTENT_LENGTH
Motivation and Context
Test case started failing
How Has This Been Tested?
Test case passes, verified in debugger that Content-Length is sent and not 0
Screenshots (if appropriate):
Types of change
Checklist: