[guiinfo] DisplayAfterSeek should not return True if playback is paused #17312
Conversation
ronie
added
Type: Improvement
| // notify GUI, skins may want to show the seekbar | ||
| CServiceBroker::GetGUI()->GetInfoManager().GetInfoProviders().GetPlayerInfoProvider().SetDisplayAfterSeek(); | ||
| // notify GUI, skins may want to show the seekbar | ||
| CServiceBroker::GetGUI()->GetInfoManager().GetInfoProviders().GetPlayerInfoProvider().SetDisplayAfterSeek(); |
There was a problem hiding this comment.
The
ColumnLimitin.clang-formatis set to100which defines line length [...]
https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md#3-formatting
| @@ -291,7 +291,7 @@ EVENT_RESULT CGUIWindowFullScreen::OnMouseEvent(const CPoint &point, const CMous | |||
| void CGUIWindowFullScreen::FrameMove() | |||
| { | |||
| float playspeed = g_application.GetAppPlayer().GetPlaySpeed(); | |||
| if (playspeed != 1.0 && !g_application.GetAppPlayer().HasGame()) | |||
| if (playspeed != 1.0 && !g_application.GetAppPlayer().HasGame() && !g_application.GetAppPlayer().IsPausedPlayback()) | |||
There was a problem hiding this comment.
The
ColumnLimitin.clang-formatis set to100which defines line length [...]
https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md#3-formatting
|
Used Win x64 test build and enabled Player.DisplayAfterSeek in DialogSeekBar. Observed video during pause/unpause and frameadvance. I no longer get the DialogSeekBar "DisplayAfterSeek" after unpausing. So looks GTG to me. |
|
I've also tested using a modded version of Estuary (see note) and it's works perfectly. Note - Something I've wanted for a long in Estuary is the ability to have reduced seekbar when paused, after this change I now have working proof of concept. |
ronie
force-pushed
the
displayafterseek
branch
from
2cc16b5
to
0582836
Compare
[guiinfo] DisplayAfterSeek should not return True if playback is paused
[guiinfo] DisplayAfterSeek should not return True if playback is paused
|
Can this fix be backported to Leia as well? This would be really handy for current setups as well. |
[guiinfo] DisplayAfterSeek should not return True if playback is paused
[guiinfo] DisplayAfterSeek should not return True if playback is paused
[guiinfo] DisplayAfterSeek should not return True if playback is paused
[guiinfo] DisplayAfterSeek should not return True if playback is paused
[guiinfo] DisplayAfterSeek should not return True if playback is paused
[guiinfo] DisplayAfterSeek should not return True if playback is paused
[guiinfo] DisplayAfterSeek should not return True if playback is paused
as requested by several skinners on the forum (https://forum.kodi.tv/showthread.php?tid=348201)
do not set the DisplayAfterSeek infobool to True when pausing a video.
@scott967 @jurialmunkey @sualfred would be nice if you could test it