[ios] set minimum ios version to 11.0, fix deprecations and cleanup dependencies

[phunkyfish]

Description

Set minimum supported iOS version of 11.0. Removes support for 32bit iOS devices (which covers iPad 1-4 and iPhone 5 and earlier).

Motivation and Context

Simplifies patching a logic around the iOS platform, especially around addons.

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Not quite sure how to categorise this.

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[phunkyfish]

Early days for this one. Plenty more to do.

[kambala-decapitator]

• tools/depends/target/fontconfig/fix-aarch64_atomics.patch:17 (if this is Kodi's patch)
• xbmc/platform/darwin/ios/XBMCController.mm:710

[phunkyfish]

@kambala-decapitator the first is still required for 64bit if I'm not mistaken. For the second it is already set to 11.0 which is what it should be, correct?

[kambala-decapitator]

oh right, first is patch :)

in the second you should remove the condition, as it's always true now.

[phunkyfish]

I assume I can condense it to this:
return UIEdgeInsetsInsetRect(self.view.bounds, m_window.safeAreaInsets);

[phunkyfish]

@Rechi should removing ios (armv7) from Jenkins be part of the PR or would that be something that must be done manually on/before merge?

[fuzzard]

xbmc/tools/depends/configure.ac

Lines 360 to 372 in a353ae2

	if test "$use_platform" = "tvos"; then
	use_cpu=arm64
	target_platform=appletvos
	platform_min_version="$target_platform-version-min=11.0"
	else
	# setup which cpu to use
	if test "x$use_cpu" = "xauto"; then
	use_cpu=arm64
	fi
	target_platform=iphoneos
	platform_min_version="$target_platform-version-min=11.0"
	fi

Can be rewritten to something like

        use_cpu=arm64
        platform_min_version="$target_platform-version-min=11.0"
        if test "$use_platform" = "tvos"; then
          target_platform=appletvos
        else
          target_platform=iphoneos
        fi

[fuzzard]

xbmc/tools/depends/configure.ac

Lines 378 to 396 in a353ae2

	if test "$use_platform" = "tvos"; then
	case $use_sdk in
	11.*);;
	12.*);;
	13.*);;
	*)
	AC_MSG_ERROR(error in configure of --with-sdk=$use_sdk)
	;;
	esac
	else
	case $use_sdk in
	11.*);;
	12.*);;
	13.*);;
	*)
	AC_MSG_ERROR(error in configure of --with-sdk=$use_sdk)
	;;
	esac
	fi

Can be rewritten like

        case $use_sdk in
          11.*);;
          12.*);;
          13.*);;
            *)
              AC_MSG_ERROR(error in configure of --with-sdk=$use_sdk)
            ;;
        esac

[fuzzard]

xbmc/tools/depends/configure.ac

Lines 400 to 403 in a353ae2

	if [ ! test "x$use_cpu" = "xarm64" ]; then
	platform_cflags+=" -mcpu=cortex-a8 -mfpu=neon"
	platform_ldflags+=" -Wl,-segalign,4000"
	fi

can be removed

[fuzzard]

There is a line in README.iOS.md under section 2. Prequisites

Device with iOS 9.0 or newer to install Kodi after build.

Will need updating.

[fuzzard]

End of section 4 in the same readme, theres a NOTE that references an ios 9 build.

NOTE: Advanced developers may want to specify an iOS SDK version (if multiple versions are installed) in the configure line(s) shown above. The example below would use the iOS SDK 9.0:

./configure --host=arm-apple-darwin --with-cpu=arm64 --with-sdk=9.0

Probably need to just alter that to 11

[fuzzard]

xbmc/xbmc/platform/darwin/DarwinUtils.mm

Lines 178 to 179 in d14495a

	// since iOS 8
	@"/var/mobile/Containers/Bundle/",

should be removable. The line below it should most likely stay as i believe its relevant for ios10/11/12

[fuzzard]

xbmc/tools/buildsteps/ios/package

Lines 10 to 15 in d14495a

	if [ "$DARWIN_ARM_CPU" == "arm64" ]
	then
	UPLOAD_FILENAME="kodi-$(getBuildRevDateStr)-ios64.deb"
	else
	UPLOAD_FILENAME="kodi-$(getBuildRevDateStr)-ios.deb"
	fi

no need for the check now with a single ios platform

UPLOAD_FILENAME="kodi-$(getBuildRevDateStr)-ios64.deb"

[fuzzard]

xbmc/tools/darwin/packaging/darwin_embedded/mkdeb-darwin_embedded.sh.in

Lines 31 to 34 in d14495a

	# check if build is 64-bit
	if [[ "$(lipo -info "$APP/@APP_NAME@" | awk '{print $NF}')" == "arm64" ]]; then
	ARM64=true
	fi

No need for the check, just set ARM64

[fuzzard]

Can probably remove the previous ARM64 check completely, and then

xbmc/tools/darwin/packaging/darwin_embedded/mkdeb-darwin_embedded.sh.in

Lines 69 to 70 in d14495a

	# package identifier for arm64
	$ARM64 && ARCHIVE=${PACKAGE_ARM64}_${VERSION}-${REVISION}_@PLATFORM@-arm.deb

Remove the $ARM64 && as every package will be 64bit

[fuzzard]

xbmc/tools/darwin/packaging/darwin_embedded/mkdeb-darwin_embedded.sh.in

Lines 80 to 89 in d14495a

	if $ARM64; then
	echo "Package: $PACKAGE_ARM64" > $DIRNAME/$PACKAGE/DEBIAN/control
	echo "Name: @APP_NAME@-${PP_DEVICE} (64-bit)" >> $DIRNAME/$PACKAGE/DEBIAN/control
	echo "Pre-Depends: cy+cpu.arm64" >> $DIRNAME/$PACKAGE/DEBIAN/control
	echo "Conflicts: $PACKAGE" >> $DIRNAME/$PACKAGE/DEBIAN/control
	echo "Replaces: $PACKAGE" >> $DIRNAME/$PACKAGE/DEBIAN/control
	else
	echo "Package: $PACKAGE" > $DIRNAME/$PACKAGE/DEBIAN/control
	echo "Name: @APP_NAME@-${PP_DEVICE}" >> $DIRNAME/$PACKAGE/DEBIAN/control
	fi

Change to just

echo "Package: $PACKAGE_ARM64"                  >  $DIRNAME/$PACKAGE/DEBIAN/control
echo "Name: @APP_NAME@-${PP_DEVICE} (64-bit)"   >> $DIRNAME/$PACKAGE/DEBIAN/control
echo "Pre-Depends: cy+cpu.arm64"                >> $DIRNAME/$PACKAGE/DEBIAN/control
echo "Conflicts: $PACKAGE"                      >> $DIRNAME/$PACKAGE/DEBIAN/control
echo "Replaces: $PACKAGE"                       >> $DIRNAME/$PACKAGE/DEBIAN/control

[fuzzard]

Remove

xbmc/tools/darwin/Support/Codesign.command

Line 10 in d14495a

LDID32="$NATIVEPREFIX/bin/ldid32"

This can be reduced to just the LDID64 lines

xbmc/tools/darwin/Support/Codesign.command

Lines 14 to 19 in d14495a

	if [ "${CURRENT_ARCH}" == "arm64" ] || [ "${CURRENT_ARCH}" == "aarch64" ]; then
	LDID=${LDID64}
	echo "using LDID64"
	else
	echo "using LDID32"
	fi

[Rechi]

First get this PR ready.
Once it is approved adjust the Jenkins configuration, run another PR build and if that reports success merge the PR.

[Rechi]

• ldid for 32 bit is still downloaded (extracted and installed)
• deployment target isn't updated
• There is still a dependency which explicitly disables a function, which is now available.

[phunkyfish]

jenkins build this please

[phunkyfish]

Ok, ready @Rechi

[phunkyfish]

@Rechi is it ok to make the Jenkins changes now?

[Rechi]

There is still a (new) hack because of the wrong host triplet.

[lrusak]

There is still a (new) hack because of the wrong host triplet.

Could you be more specific? Do you mean about the mixed usage of arm64 and aarch64?

[phunkyfish]

Maybe I’ve been looking at this too long but I’m not seeing it.

[Rechi]

This branch is 3 commits ahead, 113 commits behind xbmc:master.

https://github.com/phunkyfish/xbmc/tree/min-ios-version

So there are changes from 113 commits which are currently not included in your branch.

[phunkyfish]

Ah, that would make sense why I’m not seeing it so. At least I didn’t add the new hack!

[phunkyfish]

Ok, I removed the todo's in the two toolchain files. Any other hacks you came across @Rechi ?

I didn't spot anything additional.

[phunkyfish]

jenkins build this please

[phunkyfish]

@Rechi is it ok to make the jenkins changes now?