-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leak #17346
Fix memory leak #17346
Conversation
Thanks much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disregard this first comment.
Also st is created with new, with no corresponding delete as well in that method. Worth doing the delete for that as well?
https://github.com/Paxxi/xbmc/blob/542470e4f8ebc5ae60d52306e8740e7404f03a60/xbmc/cores/VideoPlayer/DVDDemuxers/DVDDemuxFFmpeg.cpp#L1508
@fuzzard , check the line below. One new early return was added that didn't delete stream and that's what coverity caught |
Sorry for the noise |
Fix memory leak
Fix memory leak
Fix memory leak
Fix memory leak
Fix memory leak
Fix memory leak
Fix memory leak
Fix memory leak
Fix memory leak
Description
Fixes a memory leak introduced with #17186 . I missed it but Coverity caught it 馃槃
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: