[PVR] CPVRTimerInfoTag::ConvertUTCToLocalTime: Fix leap year detection. #17421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
phunkyfish
approved these changes
Feb 29, 2020
|
Ok, but the define in the PR is human readable and makes sense. I think I prefer that over a more complex solution. Are there benefits to what you propose vs the content of the PR? Please detail those if there are. |
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Mar 2, 2020
[PVR] CPVRTimerInfoTag::ConvertUTCToLocalTime: Fix leap year detection.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Mar 4, 2020
[PVR] CPVRTimerInfoTag::ConvertUTCToLocalTime: Fix leap year detection.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
May 5, 2020
[PVR] CPVRTimerInfoTag::ConvertUTCToLocalTime: Fix leap year detection.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 3, 2020
[PVR] CPVRTimerInfoTag::ConvertUTCToLocalTime: Fix leap year detection.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
[PVR] CPVRTimerInfoTag::ConvertUTCToLocalTime: Fix leap year detection.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
[PVR] CPVRTimerInfoTag::ConvertUTCToLocalTime: Fix leap year detection.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
[PVR] CPVRTimerInfoTag::ConvertUTCToLocalTime: Fix leap year detection.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
[PVR] CPVRTimerInfoTag::ConvertUTCToLocalTime: Fix leap year detection.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 7, 2020
[PVR] CPVRTimerInfoTag::ConvertUTCToLocalTime: Fix leap year detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a stupid bug in a leap year detection macro (which I had copied from somewhere).
Runtime-tested on macOS, latest Kodi master.
@phunkyfish when you get time for a review.