Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addons][inputstream] addon "C" style fixes and doxygen define add #17461

Merged
merged 3 commits into from Mar 11, 2020

Conversation

AlwinEsch
Copy link
Member

@AlwinEsch AlwinEsch commented Mar 9, 2020

Description

These are minor changes made by #17438 which are good for me.

Commit 1:

[addons][inputstream] add inttypes.h and string.h to StreamCrypto.h

This done to match his structure parts the "C" style.

The enum and static const uint8_t FLAG_SECURE_DECODER = 1; becomes on
other request changed to match "C".

Commit 2:

[docs] update doxygen to define __cplusplus to include related parts

Also are on "xbmc/addons/kodi-addon-dev-kit/doxygen/Doxyfile" some headers
now included where for addons.

Commit 3:

[videoplayer] update TimingConstants.h to support also "C"
There was some time ago this changed to C++ style where is cool and good.

But this also used by addons and to allow use by "C" only the constexpr bring
problems.

There becomes now the same added as "C" define (style like earlier) and then
separated with a #ifdef __cplusplus between both.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@AlwinEsch AlwinEsch requested a review from Rechi March 9, 2020 16:55
@AlwinEsch AlwinEsch added Component: Binary add-ons Documentation Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Improvement non-breaking change which improves existing functionality v19 Matrix labels Mar 9, 2020
@AlwinEsch AlwinEsch added this to the Matrix 19.0-alpha 1 milestone Mar 9, 2020
@garbear
Copy link
Member

garbear commented Mar 9, 2020

Commit 1 looks ok.

Commit 2 looks ok.

Commit other 2 looks ok ;)

@lrusak the test failure is:

10:03:12 [ RUN      ] TestDateTime.GetAsTimeStamp
10:03:12 /Users/Shared/jenkins/workspace/OSX-64/xbmc/test/TestDateTime.cpp:577: Failure
10:03:12 Value of: dateTime == fileTime
10:03:12   Actual: false
10:03:12 Expected: true
10:03:12 [  FAILED  ] TestDateTime.GetAsTimeStamp (1 ms)

Does this look problematic?

EDIT: Per here it seems related to the daylight savings time change over the weekend.

@AlwinEsch
Copy link
Member Author

AlwinEsch commented Mar 9, 2020

Ups 😁 about :

Commit other 2 looks ok ;)

is 3 now 😌

@phunkyfish phunkyfish added the PR Cleanup: Recent Checked as part of PR cleanup. PR has been followed up on recently. label Mar 10, 2020
This done to match his structure parts the "C" style.

The "enum" and "static const uint8_t FLAG_SECURE_DECODER = 1;" becomes on
other request changed to match "C".
Also are on "xbmc/addons/kodi-addon-dev-kit/doxygen/Doxyfile" some headers
now included where for addons.
There was some time ago this changed to C++ style where is cool and good.

But this also used by addons and to allow use by "C" only the "constexpr" bring
problems.

There becomes now the same added as "C" define (style like earlier) and then
separated with a `#ifdef __cplusplus` between both.
@AlwinEsch AlwinEsch merged commit e366adc into xbmc:master Mar 11, 2020
@AlwinEsch AlwinEsch deleted the few-changes branch March 11, 2020 22:11
@AlwinEsch AlwinEsch removed the PR Cleanup: Recent Checked as part of PR cleanup. PR has been followed up on recently. label Mar 11, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Mar 12, 2020
[addons][inputstream] addon "C" style fixes and doxygen define add
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
[addons][inputstream] addon "C" style fixes and doxygen define add
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
[addons][inputstream] addon "C" style fixes and doxygen define add
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
[addons][inputstream] addon "C" style fixes and doxygen define add
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
[addons][inputstream] addon "C" style fixes and doxygen define add
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
[addons][inputstream] addon "C" style fixes and doxygen define add
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[addons][inputstream] addon "C" style fixes and doxygen define add
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
[addons][inputstream] addon "C" style fixes and doxygen define add
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Binary add-ons Documentation Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants