New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[addons][inputstream] addon "C" style fixes and doxygen define add #17461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlwinEsch
added
Component: Binary add-ons
Documentation
Type: Cleanup
non-breaking change which removes non-working or unmaintained functionality
Type: Improvement
non-breaking change which improves existing functionality
v19 Matrix
labels
Mar 9, 2020
Commit 1 looks ok. Commit 2 looks ok. Commit other 2 looks ok ;) @lrusak the test failure is:
Does this look problematic? EDIT: Per here it seems related to the daylight savings time change over the weekend. |
Ups 😁 about :
is 3 now 😌 |
phunkyfish
added
the
PR Cleanup: Recent
Checked as part of PR cleanup. PR has been followed up on recently.
label
Mar 10, 2020
This done to match his structure parts the "C" style. The "enum" and "static const uint8_t FLAG_SECURE_DECODER = 1;" becomes on other request changed to match "C".
Also are on "xbmc/addons/kodi-addon-dev-kit/doxygen/Doxyfile" some headers now included where for addons.
There was some time ago this changed to C++ style where is cool and good. But this also used by addons and to allow use by "C" only the "constexpr" bring problems. There becomes now the same added as "C" define (style like earlier) and then separated with a `#ifdef __cplusplus` between both.
AlwinEsch
removed
the
PR Cleanup: Recent
Checked as part of PR cleanup. PR has been followed up on recently.
label
Mar 11, 2020
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Mar 12, 2020
[addons][inputstream] addon "C" style fixes and doxygen define add
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
May 5, 2020
[addons][inputstream] addon "C" style fixes and doxygen define add
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 3, 2020
[addons][inputstream] addon "C" style fixes and doxygen define add
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
[addons][inputstream] addon "C" style fixes and doxygen define add
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
[addons][inputstream] addon "C" style fixes and doxygen define add
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
[addons][inputstream] addon "C" style fixes and doxygen define add
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
[addons][inputstream] addon "C" style fixes and doxygen define add
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 7, 2020
[addons][inputstream] addon "C" style fixes and doxygen define add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Binary add-ons
Documentation
Type: Cleanup
non-breaking change which removes non-working or unmaintained functionality
Type: Improvement
non-breaking change which improves existing functionality
v19 Matrix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are minor changes made by #17438 which are good for me.
Commit 1:
[addons][inputstream] add inttypes.h and string.h to StreamCrypto.h
This done to match his structure parts the "C" style.
The
enum
andstatic const uint8_t FLAG_SECURE_DECODER = 1;
becomes onother request changed to match "C".
Commit 2:
[docs] update doxygen to define __cplusplus to include related parts
Also are on "xbmc/addons/kodi-addon-dev-kit/doxygen/Doxyfile" some headers
now included where for addons.
Commit 3:
[videoplayer] update TimingConstants.h to support also "C"
There was some time ago this changed to C++ style where is cool and good.
But this also used by addons and to allow use by "C" only the
constexpr
bringproblems.
There becomes now the same added as "C" define (style like earlier) and then
separated with a
#ifdef __cplusplus
between both.Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: