[Estuary] hide remaining time when fullscreen-info is displayed

[howie-f]

Description

cosmetic surgery on the estuary-seekbar.
tags are overlapping remaining time.

Screenshots:

Types of change

• Cosmetic change (non-breaking change that doesn't touch code)

@ronie please review the only reasonable solution that came to my mind

[ronie]

thanx, that's indeed an issue.

however, on the left side Estuary optionally displays chapter info, so moving it there doesn't really solve it.

perhaps move it to the top-right, and place it below the 'Ends at" line?

[howie-f]

hm, ok i'll try that.... not many options but sounds good

so how's that?

---

EDIT2: but to be honest i would prefer s.th. like this:

[ronie]

but to be honest i would prefer s.th. like this

yes, looks good to me as well.
feel free to go with that if you like.

[howie-f]

ok - ready to go. thanks

[ronie]

looks good overall. just a bit of fine-tuning required.
thx!

[chewitt]

I always understood (and appreciate) the media flags in list views as sometimes I have different versions of media (1080p and 4k HDR for testing) and 2.0 and DTS versions of albums. However once I selected the media I don't really need to see the flags again - alongside media controls on the OSD when it's visible. Could we remove the flagging and leave 'remaining' time in the current bottom-right location?

[ksooo]

How can I reproduce the original problem? I'm using this a lot and never have seen that.

Is it specific to Matrix?

[howie-f]

How can I reproduce the original problem? I'm using this a lot and never have seen that.

@ksooo i just play any video and then press "info" on my "official-kodi-remote (ios)", same with live-tv

[DaVukovic]

Totally agree with @chewitt
I would suggest to remove those flags on that info screen. We are currently trying to move something to a location where it simply doesn't match (sorry if that sounds harsh):

The section above that green line is darkened and we already have specific things which are located inside this section. As one can see, the "Restzeit" simply doesn't match inside this section (beside we would make it bigger which would destroy the overall-Estuary-layout).

If I have a voice in that case, I´m against this change and I would suggest to remove those flags from that screen completely. The "time remaining" label matched perfectly before the flags have been added.

Jm2c

[howie-f]

We are currently trying to move something to a location where it simply doesn't match

@DaVukovic his version is obsolete. the "remaining"-label is back in the seekbar.
generally i'm fine with anything but overlapping labels. so you decide

[DaVukovic]

I'm not deciding anything. I'm saying that we have a change which hasn't been introduced by you (the flags on that info screen). The remaining-label matched perfectly where it has been before those flags have been added. You are trying to fix that somehow and I appreciate that.

From my point of view, every other location of that remaining label looks either "meh" or doesn't fit or isn't the correct location as there are already other labels located. The flags shouldn't have been added in the first place on this screen. So my suggestion is to don't touch the location of the remaining label but to remove those flags from the info screen

I'm also against overlapping labels. Don't get me wrong. I would simply solve it in another way

[howie-f]

Clarify: you decide = the team decides. don‘t geht me wrong. there‘s no problem at all.

[phunkyfish]

Does some have a screenshot showing the media flags conflict? (Sorry nowhere near a kodi at the moment)

[howie-f]

Does some have a screenshot showing the media flags conflict? (Sorry nowhere near a kodi at the moment)

@phunkyfish first screenshot in this pr

[phunkyfish]

Does some have a screenshot showing the media flags conflict? (Sorry nowhere near a kodi at the moment)

@phunkyfish first screenshot in this pr

Sorry, too early ;)

[howie-f]

Is it specific to Matrix?

yes.
Leia hides the "Remaining"-Label as soon as the video-info shows up.
The visible-conditions for both Leia and Matrix are the same:
<visible>![Player.ShowInfo | Window.IsVisible(playerprocessinfo) | VideoPlayer.HasEpg]</visible>
Then i must admit that changing the skin would be the wrong approach.
i'll try to track that down

[jjd-uk]

Personally I think the media flags need to stay, what I think is out of place is the chapter info down there at the bottom, as we only have room for the Chapter Numbers. If we move chapter info to the top (like it is for Confluence) then we have the space to also display Chapter Name.

So this is what I'd have in mind

From a cursory glance moving media flags to the left with chapter moved to the top only produces a conflict for displaying rating on music viz info but that can solved by moving rating to the right.

If this is an acceptable solution then I'll submit to avoid messing howie-f about (I'd noticed the overlap as well so had the code partially done).

For comparison:

Current Estuary with no Chapter Name

Confluence

[ronie]

ask 10 people and get 20 different opinions :-)

[jjd-uk]

Note I'm ok for this to merge as is. I can do my changes as a follow up once I've fully proven them.

[howie-f]

believe it or not:
turns out that removing (yet nearly empty) DialogFullScreenInfo.xml leads to previous, imo correct, Leia-behavior. see the actual commit history. must be work in progess on that? then this pr can either close or the first solution applies.. i'm fine with both.

[jjd-uk]

I can confirm.

Overlap starts with Windows build KodiSetup-20191109-8b6bf13d after #16878

Previously Time Remaining was only shown when seeking and full screen info was NOT being shown. That PR somehow introduced Time Remaining also being shown in full screen info thus causing the overlap.

[howie-f]

@ronie finally the correct solution is simple and everyone should be happy now.
to me this is ready to merge. thanks to everyone for input

[howie-f]

after #16878
that was the crucial hint, thanks @jjd-uk

[jjd-uk]

Personally I think having the Time Remaining when in full screen info is a good idea even if it was unintentional, but this restores the previous behaviour so I think it should be merged if ronie is ok with it, or he has a better fix.

[howie-f]

Time Remaining when in full screen info is a good idea

sure, i absolutely agree, if the space is there like in your screenshots (which i like)
now we know how to get it back

[ronie]

thanx for the effort to get to the bottom of it!

[howie-f]

all's well that ends well :-)