[Addons] Remove noicon/nofanart and old fallback paths to the root of…

[enen92]

Description

This PR removes the fallback behaviour for icon.png and fanart.jpg (as well as the noicon and nofanart elements in addon.xml to avoid the checks).

Motivation and Context

Same functionality can be achieved via the assets element since krypton. Majority of the addons are python and we have enforced the requirement for the assets element in all repository submissions since the krypton branch.

How Has This Been Tested?

Compile and runtime tested

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[AlwinEsch]

Must look which binary addons need update, found icon.png used on 133 and the <icon>[.../]icon.png</icon> only on 108 addons.

But from my side no problem to remove and give addon itself the right to give them.

As it also standard since v17 😄

[enen92]

@AlwinEsch I can make PRs to binary addons that use icon.png and fanart.jpg and don't define them in assets (same for noicon and nofanart). Can you point me to where I can find the whole list of available binary addons?

[ronie]

look ok to me

[garbear]

@AlwinEsch I can make PRs to binary addons that use icon.png and fanart.jpg and don't define them in assets (same for noicon and nofanart). Can you point me to where I can find the whole list of available binary addons?

@enen92 just passing on something I found, noicon and nofanart have no analog tags in the new system, they are indicated by simply having an assets tag with no icon or fanart respectively

[AlwinEsch]

I currently add some of the:

    <assets>
      <icon>icon.png</icon>
    </assets>

to addons where not have.

[AlwinEsch]

Apart from xbmc/vfs.sftp#51 and game.libretro.mame, all binary addons are now correct, although I may have missed one, but shouldn't be much then.

I'll take care of it in my rounds. In terms of binaries, the request would be OK for me.

[AlwinEsch]

Reminder to not let the request perish 😄

[enen92]

@AlwinEsch I saw you took care of the binary addons. Is still anything left that I need to do? Or can we just invoke build and merge?

[AlwinEsch]

They should all be changed, I look further in future about, but thing there is nothing anymore without assets.

[enen92]

jenkins build and merge