[settings/lib] implement missing CSettingList/Int/String::MergeDetails() #17503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Montellese
added
Type: Fix
Montellese
force-pushed
the
bugfix/setting_merge_details
branch
from
464c34e
to
5c800f9
Compare
Rechi
reviewed
Apr 17, 2020
Montellese
force-pushed
the
bugfix/setting_merge_details
branch
from
5c800f9
to
f655d64
Compare
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 20, 2020
…tails [settings/lib] implement missing CSettingList/Int/String::MergeDetails()
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
May 5, 2020
…tails [settings/lib] implement missing CSettingList/Int/String::MergeDetails()
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 3, 2020
…tails [settings/lib] implement missing CSettingList/Int/String::MergeDetails()
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
…tails [settings/lib] implement missing CSettingList/Int/String::MergeDetails()
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
…tails [settings/lib] implement missing CSettingList/Int/String::MergeDetails()
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
…tails [settings/lib] implement missing CSettingList/Int/String::MergeDetails()
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
…tails [settings/lib] implement missing CSettingList/Int/String::MergeDetails()
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
…tails [settings/lib] implement missing CSettingList/Int/String::MergeDetails()
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
…tails [settings/lib] implement missing CSettingList/Int/String::MergeDetails()
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
…tails [settings/lib] implement missing CSettingList/Int/String::MergeDetails()
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 7, 2020
…tails [settings/lib] implement missing CSettingList/Int/String::MergeDetails()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I just noticed that in 0511fb2 from #16773 I forgot to fully implement the
CSetting::MergeDetails()method forCSettingList,CSettingIntandCSettingString.Types of change
Checklist: