New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust mouse and gesture handling #17548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: sorry commented on wrong PR while reviewing #17543... when's that coffee kicking in this morning...
I'll check this out soon.
This is a welcome change, it had always annoyed me slightly. Could you split somewhere along the bullets in the description? |
Thanks for splitting. You can see how it divided up the code into disparate components: gui/, input/ and platform/. Untangling the code was helpful for me. Left some comments. I haven't worked with touch or mouse in the GUI yet, so I'm not able to analyze the logic, but if something breaks later that's what follow up PRs are for. |
I removed the android one - will be in a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any unresolved comments.
Jenkins build this please |
3d2dfbf
to
918fcfc
Compare
* Disable MouseMove Select / fix middle wheel / stop inertial early * Adjust gesture timing constants / respect DPI for inertial scrolling
* Disable MouseMove Select / fix middle wheel / stop inertial early * Adjust gesture timing constants / respect DPI for inertial scrolling
I am developing my own skin which I plan to release for Kodi 19. This change is very welcome for Estuary for example (Estuary is using fixedlists in all list views), it works brilliantly for fixedlist containers but feels not natural for panels, at least it doesn't for me. Some screenshots of my mouse skin, I even managed to make home widgets to scroll with a mouse by using hidden containers, (the main reason I am developing this skin, mouse handling of widgets). |
I'll revert the mouse part, except the fix for middle wheel later the day |
Thank you peak3d, if you find time please have a look if you can keep this behaviour for fixedlists only. |
Any luck in reverting the mouse part @peak3d? On OSX mouse can't be used to navigate left nav or tiled menus. BTW, cursors work OK, so there is a workaround. |
* Disable MouseMove Select / fix middle wheel / stop inertial early * Adjust gesture timing constants / respect DPI for inertial scrolling
* Disable MouseMove Select / fix middle wheel / stop inertial early * Adjust gesture timing constants / respect DPI for inertial scrolling
* Disable MouseMove Select / fix middle wheel / stop inertial early * Adjust gesture timing constants / respect DPI for inertial scrolling
* Disable MouseMove Select / fix middle wheel / stop inertial early * Adjust gesture timing constants / respect DPI for inertial scrolling
* Disable MouseMove Select / fix middle wheel / stop inertial early * Adjust gesture timing constants / respect DPI for inertial scrolling
* Disable MouseMove Select / fix middle wheel / stop inertial early * Adjust gesture timing constants / respect DPI for inertial scrolling
* Disable MouseMove Select / fix middle wheel / stop inertial early * Adjust gesture timing constants / respect DPI for inertial scrolling
* Disable MouseMove Select / fix middle wheel / stop inertial early * Adjust gesture timing constants / respect DPI for inertial scrolling
* Disable MouseMove Select / fix middle wheel / stop inertial early * Adjust gesture timing constants / respect DPI for inertial scrolling
Description
Commit 1:
This PR affects mouse and touch behaviour:
Commit 2:
Motivation and Context
In the last period I tested lot on android phones / and for validation on my windows laptop with touch and mouse support. Navigating with mouse felt something nervous / stressing, this PR reduces select actions to have a more relexed navigation. Beside this it will save battery live due to much less image / content change actions.
How Has This Been Tested?
Navigate inside main menu and video library with android phone / windows laptop (touch and mouse)
Types of change