Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addons][pvr] remove more deprecated parts and make PVR tables in own parts #17586

Merged
merged 11 commits into from
Apr 24, 2020

Conversation

AlwinEsch
Copy link
Member

@AlwinEsch AlwinEsch commented Mar 30, 2020

Description

Commit 1:

[pvr] remove deprecated inputstreamaddon property

This done by another named inputstreamclass.

Commit 2:

[pvr] make props and functions to/from Kodi in own parts

This is to prevent problems by add of something where has needed before
a complete API increase (if was something on props or callbacks).

Now have every part a own created memory where can be changed without
attack of followed parts.

Commit 3:

[addons][pvr] remove deprecated kodi_vfs_types.h

The two structures currently used in it are moved to libXBMC_addon.h
and kodi_vfs_types.h deleted.

The rest of them was used years before for the old VFS addon way.

Commit 4:

[addons][pvr] remove deprecated interface parts

This remove some parts where since long time no more used or
present on other place.

Commit 5:

[addons][pvr] move xbmc_epg_types.h to xbmc_pvr_types.h

This is another change to clean up the old interface where the PVR
related EPG data is moved to it and xbmc_epg_types.h deleted.

Also is the EPG_EVENT_CONTENTMASK added to a enum where match more his type.

Commit 6:

[addons][pvr] correct CPVRClient::GetDriveSpace call

This change is to make it equal to all other calls and use given
"const AddonInstance* addon" value.

Commit 7:

[addons][pvr] use STREAM_MAX_PROPERTY_COUNT from inputstream also for pvr

Thought to use the same on pvr and inputstream to confirm both places have the
same size.

This can prevent some update problems, for PVR this not related to his
sources, as they not use it. Only used for PVR inside Kodi.

Commit 8:

[addons][pvr] remove stream properties and do over inputstream

Before was them in inputstream and the same as copy in PVR, this now remove it
there to use also them from inputstream. This to make in case of change more
sure to have equal and to have it cleaner.

Commit 9:

increase PVR API version to 6.4.0

Motivation and Context

To reduce further the size of #16485 and take unrelated minor things from there.

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@AlwinEsch AlwinEsch added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Component: PVR API change: PVR v19 Matrix labels Mar 30, 2020
@AlwinEsch AlwinEsch added this to the Matrix 19.0-alpha 1 milestone Mar 30, 2020
This was referenced Mar 30, 2020
@AlwinEsch AlwinEsch force-pushed the remove-part branch 2 times, most recently from 27c24ec to 2163996 Compare April 23, 2020 18:08
This done by another named "inputstreamclass".
This is to prevent problems by add of something where has needed before
a complete API increase (if was something on props or callbacks).

Now have every part a own created memory where can be changed without
attack of followed parts.
The two structures currently used in it are moved to libXBMC_addon.h
and kodi_vfs_types.h deleted.
This remove some parts where since long time no more used or
present on other place.
This is another change to clean up the old interface where the PVR
related EPG data is moved to it and xbmc_epg_types.h deleted.
This change is to make it equal to all other calls and use given
"const AddonInstance* addon" value.
… pvr

Thought to use the same on pvr and inputstream to confirm both places have the
same size.

This can prevent some update problems, for PVR this not related to his
sources, as they not use it. Only used for PVR inside Kodi.
Before was them in inputstream and the same as copy in PVR, this now remove it
there to use also the defines from inputstream.
This to make in case of change more sure to have equal and to have it cleaner.

Further is the documentation a bit changes to match the rework part.
The LOG_NOTICE is LOG_INFO. Also are the LOG_WARNING and LOG_FATAL added.

Further is the namespace ADDONS removed from them, to allow combine with
new interface on next requests.
@AlwinEsch
Copy link
Member Author

jenkins build this please

@AlwinEsch AlwinEsch merged commit d1e341c into xbmc:master Apr 24, 2020
@AlwinEsch AlwinEsch deleted the remove-part branch April 24, 2020 15:58
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Apr 27, 2020
[addons][pvr] remove more deprecated parts and make PVR tables in own parts
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
[addons][pvr] remove more deprecated parts and make PVR tables in own parts
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
[addons][pvr] remove more deprecated parts and make PVR tables in own parts
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
[addons][pvr] remove more deprecated parts and make PVR tables in own parts
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
[addons][pvr] remove more deprecated parts and make PVR tables in own parts
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
[addons][pvr] remove more deprecated parts and make PVR tables in own parts
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
[addons][pvr] remove more deprecated parts and make PVR tables in own parts
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[addons][pvr] remove more deprecated parts and make PVR tables in own parts
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[addons][pvr] remove more deprecated parts and make PVR tables in own parts
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[addons][pvr] remove more deprecated parts and make PVR tables in own parts
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
[addons][pvr] remove more deprecated parts and make PVR tables in own parts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change: PVR Component: PVR Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants