Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRPRendererDMA: use TEXTURE shader so DMA can be used with OpenGL #17640

Merged
merged 2 commits into from Apr 12, 2020
Merged

CRPRendererDMA: use TEXTURE shader so DMA can be used with OpenGL #17640

merged 2 commits into from Apr 12, 2020

Conversation

lrusak
Copy link
Contributor

@lrusak lrusak commented Apr 8, 2020

Simple change to use the TEXTURE shader. I tested this on OpenGLES and didn't see any issues. This is needed as the TEXTURE_NOALPHA shader method isn't available on OpenGL.

I've also added a commit to remove the unused TEXTURE_RGBA_OES that was made obsolete in #17543

after this PR #17558 can get merged

@lrusak lrusak added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Improvement non-breaking change which improves existing functionality Platform: Linux v19 Matrix labels Apr 8, 2020
@lrusak lrusak added this to the Matrix 19.0-alpha 1 milestone Apr 8, 2020
@lrusak lrusak requested a review from garbear April 8, 2020 21:19
@lrusak lrusak mentioned this pull request Apr 8, 2020
Merged
@a1rwulf
Copy link
Member

a1rwulf commented Apr 9, 2020

LGTM

@garbear
Copy link
Member

garbear commented Apr 10, 2020

Was TEXTURE_RGBA_OES always unused? Can you reference the commit or PR that orphaned it?

@lrusak
Copy link
Contributor Author

lrusak commented Apr 10, 2020

Was TEXTURE_RGBA_OES always unused? Can you reference the commit or PR that orphaned it?

I did 😝

I've also added a commit to remove the unused TEXTURE_RGBA_OES that was made obsolete in #17543

@lrusak lrusak merged commit 46aac25 into xbmc:master Apr 12, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Apr 14, 2020
@lrusak @Maven85
Merge pull request xbmc#17640 from lrusak/dma-shader
3a1977d 
CRPRendererDMA: use TEXTURE shader so DMA can be used with OpenGL
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Apr 16, 2020
@lrusak @Maven85
Merge pull request xbmc#17640 from lrusak/dma-shader
2136039 
CRPRendererDMA: use TEXTURE shader so DMA can be used with OpenGL
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
@lrusak @Maven85
Merge pull request xbmc#17640 from lrusak/dma-shader
dedc9ba 
CRPRendererDMA: use TEXTURE shader so DMA can be used with OpenGL
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
@lrusak @Maven85
Merge pull request xbmc#17640 from lrusak/dma-shader
93c8ff5 
CRPRendererDMA: use TEXTURE shader so DMA can be used with OpenGL
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
@lrusak @Maven85
Merge pull request xbmc#17640 from lrusak/dma-shader
10b1b5a 
CRPRendererDMA: use TEXTURE shader so DMA can be used with OpenGL
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
@lrusak @Maven85
Merge pull request xbmc#17640 from lrusak/dma-shader
93c7fd4 
CRPRendererDMA: use TEXTURE shader so DMA can be used with OpenGL
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
@lrusak @Maven85
Merge pull request xbmc#17640 from lrusak/dma-shader
4dfed30 
CRPRendererDMA: use TEXTURE shader so DMA can be used with OpenGL
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
@lrusak @Maven85
Merge pull request xbmc#17640 from lrusak/dma-shader
9a90dc5 
CRPRendererDMA: use TEXTURE shader so DMA can be used with OpenGL
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
@lrusak @Maven85
Merge pull request xbmc#17640 from lrusak/dma-shader
f0511f2 
CRPRendererDMA: use TEXTURE shader so DMA can be used with OpenGL
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
@lrusak @Maven85
Merge pull request xbmc#17640 from lrusak/dma-shader
1f37b6a 
CRPRendererDMA: use TEXTURE shader so DMA can be used with OpenGL
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
@lrusak @Maven85
Merge pull request xbmc#17640 from lrusak/dma-shader
1deae5c 
CRPRendererDMA: use TEXTURE shader so DMA can be used with OpenGL
@lrusak lrusak deleted the dma-shader branch February 11, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbear garbear garbear approved these changes

Assignees
No one assigned
Labels
Platform: Linux Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-alpha 1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lrusak @a1rwulf @garbear