New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmake] change warnings to status as it's only for indication #17657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrusak
added
Type: Improvement
non-breaking change which improves existing functionality
Platform: Linux
CMake
v19 Matrix
labels
Apr 11, 2020
To have them as status looks good. Possible to add maybe also another text, that a user know how this is related? Only maybe the users can get a question mark, for what not work in this case. |
jenkins build this please |
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 20, 2020
[cmake] change warnings to status as it's only for indication
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
May 5, 2020
[cmake] change warnings to status as it's only for indication
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 3, 2020
[cmake] change warnings to status as it's only for indication
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
[cmake] change warnings to status as it's only for indication
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
[cmake] change warnings to status as it's only for indication
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
[cmake] change warnings to status as it's only for indication
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
[cmake] change warnings to status as it's only for indication
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
[cmake] change warnings to status as it's only for indication
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
[cmake] change warnings to status as it's only for indication
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
[cmake] change warnings to status as it's only for indication
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 7, 2020
[cmake] change warnings to status as it's only for indication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CMake
Platform: Linux
Type: Improvement
non-breaking change which improves existing functionality
v19 Matrix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to show a cmake warning just because the path isn't found. Just including it in the status is good enough.
before:
after: