Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] change warnings to status as it's only for indication #17657

Merged
merged 1 commit into from Apr 20, 2020

Conversation

lrusak
Copy link
Contributor

@lrusak lrusak commented Apr 11, 2020

We don't need to show a cmake warning just because the path isn't found. Just including it in the status is good enough.

before:

-- System type: Linux
-- Linker: GNU gold
CMake Warning at cmake/scripts/linux/ArchSetup.cmake:96 (message):
  include/linux/udmabuf.h not found
Call Stack (most recent call first):
  cmake/scripts/common/ArchSetup.cmake:78 (include)
  CMakeLists.txt:34 (include)


CMake Warning at cmake/scripts/linux/ArchSetup.cmake:103 (message):
  include/linux/dma-heap.h not found
Call Stack (most recent call first):
  cmake/scripts/common/ArchSetup.cmake:78 (include)
  CMakeLists.txt:34 (include)


-- Core system type: linux
-- Platform: WAYLAND

after:

-- System type: Linux
-- Linker: GNU gold
-- include/linux/udmabuf.h not found
-- include/linux/dma-heap.h not found
-- Core system type: linux
-- Platform: WAYLAND

@lrusak lrusak added Type: Improvement non-breaking change which improves existing functionality Platform: Linux CMake v19 Matrix labels Apr 11, 2020
@lrusak lrusak added this to the Matrix 19.0-alpha 1 milestone Apr 11, 2020
@AlwinEsch
Copy link
Member

AlwinEsch commented Apr 11, 2020

To have them as status looks good.

Possible to add maybe also another text, that a user know how this is related?
I think this nothing change in Kodi's work.

Only maybe the users can get a question mark, for what not work in this case.

@phunkyfish
Copy link
Contributor

jenkins build this please

@lrusak lrusak merged commit 7af85a0 into xbmc:master Apr 20, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Apr 20, 2020
[cmake] change warnings to status as it's only for indication
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
[cmake] change warnings to status as it's only for indication
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
[cmake] change warnings to status as it's only for indication
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
[cmake] change warnings to status as it's only for indication
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
[cmake] change warnings to status as it's only for indication
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
[cmake] change warnings to status as it's only for indication
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
[cmake] change warnings to status as it's only for indication
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[cmake] change warnings to status as it's only for indication
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[cmake] change warnings to status as it's only for indication
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[cmake] change warnings to status as it's only for indication
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
[cmake] change warnings to status as it's only for indication
@lrusak lrusak deleted the cmake-linux-message branch February 11, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake Platform: Linux Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants