[python] masking support for numeric input

[ronie]

while the option to mask text input is available in python (ie. when entering a password), it was lacking support for numeric input.

this PR adds numeric masking support to:

• edit controls

self.edit = xbmcgui.ControlEdit(100, 250, 125, 75, 'Password')
self.edit.setType(xbmcgui.INPUT_TYPE_PASSWORD_NUMBER_VERIFY_NEW)

• dialog numeric

xbmcgui.Dialog().numeric(4, 'Enter password')

@MilhouseVH

[MilhouseVH]

Thanks @ronie - we'll give it a test!

[enen92]

Can you explain why the "verify new" in the constant name? Why not simply INPUT_TYPE_NUMBER_MASKED?

[ronie]

these are 1:1 mappings to:

xbmc/xbmc/guilib/GUIEditControl.h

Lines 26 to 42 in d3a641f

	class CGUIEditControl : public CGUIButtonControl
	{
	public:
	enum INPUT_TYPE {
	INPUT_TYPE_READONLY = -1,
	INPUT_TYPE_TEXT = 0,
	INPUT_TYPE_NUMBER,
	INPUT_TYPE_SECONDS,
	INPUT_TYPE_TIME,
	INPUT_TYPE_DATE,
	INPUT_TYPE_IPADDRESS,
	INPUT_TYPE_PASSWORD,
	INPUT_TYPE_PASSWORD_MD5,
	INPUT_TYPE_SEARCH,
	INPUT_TYPE_FILTER,
	INPUT_TYPE_PASSWORD_NUMBER_VERIFY_NEW
	};

guess the 'verify' bit relates to the fact you need to enter a password twice when setting it, the second time is done to verify you didn't make a typo.

[MilhouseVH]

I guess what I really need, which I suspect is going to be more work, is a new INPUT_TYPE_PASSWORD_NUMBER that would accept only masked digits and that would return the entered digits. Ideally with a configurable heading. 😄

[AlwinEsch]

Maybe remove then direct on description text the (...), think is from time where it was not included inside a table, the old:

xbmcgui.INPUT_TYPE_TEXT (standard keyboard)

[MilhouseVH]

Many thanks for this, @ronie, however this PR isn't quite what I had in mind.

The type=4 numeric dialog is implementing the new PIN "set" logic (ie. enter a "new" password and then "verify" the same password by entering it a second time), when (as @enen92 suggests) we actually only want to mask the PIN of the user as they attempt to unlock the PIN restricted resource.

It's entirely possible type=4 as implemented by this PR would be useful in some scenario, but would it be possible to mask the single-entry numeric dialog?

Maybe a type=5 could be used to accept masked numeric input (without verify). If it can allow the heading to be configured as well that would be gravy! :)

Currently we have this dialog (unmasked):

[CastagnaIT]

i agree with MilhouseVH,
similar case for the PIN, is in VOD addons,
you do not know the value to verify, the "verify" is demanded to VOD service server that verify the PIN entered and return if it is valid or not

so a masked numeric input (without verify) is required, would be the most useful method

[ronie]

thanx @MilhouseVH / @CastagnaIT i now get what you were looking for.

i've added another option to mask regular numeric input:
pwd = xbmcgui.Dialog().numeric(0, 'Enter PIN', bHiddenInput=True)

please test and let me know if i got it right this time ;-)

[MilhouseVH]

Thanks @ronie - this PR is working perfectly now for my use-case!

[MilhouseVH]

I'll include this for testing in my LibreELEC nightly builds, assuming it doesn't merge beforehand. Thanks again!

[CastagnaIT]

Tested is working good thanks!

[ronie]

jenkins build this please

[MilhouseVH]

Thanks @ronie!