New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Improve build performance on windows #17671
Conversation
Using C++ Build Insights in VS2019 I recorded a build and looked at time spent parsing header files. This PR adds some of the slow headers to pch. Rough numbers on before after on my machine Debug: - Before: 00:11:35 - After: 00:07:58 RelWithDebInfo - Before: 00:21:48 - After: 00:17:15 measured using msbuild kodi.sln -t:Clean -P:Configuration=RelWithDebInfo msbuild kodi.sln -t:Build -P:Configuration=RelWithDebInfo
Just something to keep in mind for the future, native support for precompiled headers was added to CMake in 3.16: https://cmake.org/cmake/help/latest/command/target_precompile_headers.html |
The amount of coffee I don't drink waiting for kodi to compile is coming out of your paycheck. Nice timing stats. |
When the clang commit comes first, git blame is more beautiful with relevant commit messages appearing instead of clang format lemons. For next time. |
[Windows] Improve build performance on windows
[Windows] Improve build performance on windows
[Windows] Improve build performance on windows
[Windows] Improve build performance on windows
[Windows] Improve build performance on windows
[Windows] Improve build performance on windows
[Windows] Improve build performance on windows
[Windows] Improve build performance on windows
[Windows] Improve build performance on windows
[Windows] Improve build performance on windows
[Windows] Improve build performance on windows
Description
Using C++ Build Insights in VS2019 I recorded a build
and looked at time spent parsing header files. This PR
adds some of the slow headers to pch.
Rough numbers on before after on my machine
Debug:
RelWithDebInfo
measured using
msbuild kodi.sln -t:Clean -P:Configuration=RelWithDebInfo
msbuild kodi.sln -t:Build -P:Configuration=RelWithDebInfo
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: