New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return early in case of maximum ammount of plugin resolution attempts #17679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rechi
reviewed
Apr 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the current code guidelines.
7 tasks
phunkyfish
approved these changes
May 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
May 5, 2020
Return early in case of maximum ammount of plugin resolution attempts
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
May 5, 2020
Return early in case of maximum ammount of plugin resolution attempts
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 3, 2020
Return early in case of maximum ammount of plugin resolution attempts
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
Return early in case of maximum ammount of plugin resolution attempts
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
Return early in case of maximum ammount of plugin resolution attempts
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
Return early in case of maximum ammount of plugin resolution attempts
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
Return early in case of maximum ammount of plugin resolution attempts
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
Return early in case of maximum ammount of plugin resolution attempts
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
Return early in case of maximum ammount of plugin resolution attempts
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
Return early in case of maximum ammount of plugin resolution attempts
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 7, 2020
Return early in case of maximum ammount of plugin resolution attempts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment kodi crashes if playing a plugin
CFileItem
that still has aplugin://
path in thedynPath
after the limit of 5 resolution attempts has been reached.Also, if the
plugin://
path being played sets the resolved to an empty path (thusGetDynPath()
falls back topath
) same issue will occur.Motivation and Context
Kodi should not crash :)
How Has This Been Tested?
Easiest way to reproduce the problem in Kodi master:
Types of change
Checklist: