Fix missing cast to void* in %p format #17683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Would it not make more sense to just update the log call to use |
|
I just didn't want to touch more than absolutely necessary :P |
|
funny, |
|
@lrusak updated |
lrusak
approved these changes
Apr 16, 2020
POSIX says %p argument must be pointer to void. Newer libfmt seems to have an issue with arbitary pointers, even failing at compile time, so make sure the cast is there (fmt::ptr casts to void*).
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 17, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 17, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 17, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 17, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 17, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 17, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 17, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 18, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
May 5, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 3, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
Fix missing cast to void* in %p format
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 7, 2020
Fix missing cast to void* in %p format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSIX says %p argument must be pointer to void. Newer libfmt seems to
have an issue with arbitary pointers, even failing at compile time, so
make sure the cast is there.