Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up PVR as per clang-tidy report #17685

Merged
merged 3 commits into from Apr 16, 2020
Merged

Tidy up PVR as per clang-tidy report #17685

merged 3 commits into from Apr 16, 2020

Conversation

phunkyfish
Copy link
Contributor

Description

Report here: https://jenkins.kodi.tv/view/Helpers/job/LINUX-64-Static-Analysis/1/clang-tidy/

There were a couple of values stored and not used, a good few range based loops that could be using references and some virtual calls in constructors/destructors.

Motivation and Context

The report ;)

How Has This Been Tested?

OSX using pvr iptvsimple and vuplus.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@phunkyfish phunkyfish requested a review from ksooo as a code owner April 16, 2020 16:58
@phunkyfish phunkyfish added Component: PVR Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v19 Matrix labels Apr 16, 2020
@phunkyfish phunkyfish added this to the Matrix 19.0-alpha 1 milestone Apr 16, 2020
ksooo
ksooo approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@phunkyfish
Copy link
Contributor Author

LINUX-64-Wayland and LINUX-64-GBM failures unrelated.

@phunkyfish phunkyfish merged commit 726d20d into xbmc:master Apr 16, 2020
@phunkyfish phunkyfish deleted the pvr-tidyness branch April 16, 2020 19:38
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Apr 17, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17685 from phunkyfish/pvr-tidyness
a787153 
Tidy up PVR as per clang-tidy report
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17685 from phunkyfish/pvr-tidyness
d13ef4c 
Tidy up PVR as per clang-tidy report
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17685 from phunkyfish/pvr-tidyness
ae6fa07 
Tidy up PVR as per clang-tidy report
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17685 from phunkyfish/pvr-tidyness
a352050 
Tidy up PVR as per clang-tidy report
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17685 from phunkyfish/pvr-tidyness
dc19896 
Tidy up PVR as per clang-tidy report
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17685 from phunkyfish/pvr-tidyness
dcba96b 
Tidy up PVR as per clang-tidy report
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17685 from phunkyfish/pvr-tidyness
27cfb67 
Tidy up PVR as per clang-tidy report
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17685 from phunkyfish/pvr-tidyness
426151c 
Tidy up PVR as per clang-tidy report
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17685 from phunkyfish/pvr-tidyness
67cfe8d 
Tidy up PVR as per clang-tidy report
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17685 from phunkyfish/pvr-tidyness
7857026 
Tidy up PVR as per clang-tidy report
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksooo ksooo ksooo approved these changes

@AlwinEsch AlwinEsch AlwinEsch approved these changes

Assignees
No one assigned
Labels
Component: PVR Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-alpha 1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phunkyfish @ksooo @AlwinEsch