New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Windows build readme to match current VS2017 and java installers #17695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @matthuisman
ooops, deleted this branch by accident but then restored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except for the comment. If that is tested then go ahead and merge.
Thanks @matthuisman 😀
Did you close this by accident again @matthuisman ? |
I’m going to assume a yes 😉 |
After the comments - i wasnt actually sure if those arm libraries where needed or not. I never even opened VS. I just followed the build commands and did it in command prompt. All I know at moment is I didn't need them for the below to make a working kodi.exe I'll try run a BuildSetup.bat now without them and see if that completes What else is interesting, when I did my first build of kodi.exe and copied into nightly directory, the nightly didn't have libdvdnav.dll (needed to copy that over). So not sure what is happening there. Also, the docs make it sound like the kodi.exe should just run in it's own folder. Should I update this PR to remove the (if compiling for ARM) notes? |
I think either remove it or add the suggestions I made to change it to (if not compiling arm or uwp). You should be able to accept the edits right on the page under the changes tab. You don't have to test it, I tested it myself yesterday |
Co-Authored-By: Pär Björklund <per.bjorklund@gmail.com>
Co-Authored-By: Pär Björklund <per.bjorklund@gmail.com>
done :) |
Thanks again 😀 |
Update Windows build readme to match current VS2017 and java installers
Update Windows build readme to match current VS2017 and java installers
Update Windows build readme to match current VS2017 and java installers
Update Windows build readme to match current VS2017 and java installers
Update Windows build readme to match current VS2017 and java installers
Update Windows build readme to match current VS2017 and java installers
Update Windows build readme to match current VS2017 and java installers
Update Windows build readme to match current VS2017 and java installers
Update Windows build readme to match current VS2017 and java installers
Update Windows build readme to match current VS2017 and java installers
Update Windows build readme to match current VS2017 and java installers
Description
Few minor changes I noticed today as building Kodi
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: