Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows build readme to match current VS2017 and java installers #17695

Merged
merged 3 commits into from Apr 23, 2020
Merged

Update Windows build readme to match current VS2017 and java installers #17695

merged 3 commits into from Apr 23, 2020

Conversation

matthuisman
Copy link
Contributor

@matthuisman matthuisman commented Apr 19, 2020

Description

Few minor changes I noticed today as building Kodi

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

Copy link
Contributor

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matthuisman

@phunkyfish phunkyfish added Component: Documentation Type: Improvement non-breaking change which improves existing functionality v19 Matrix labels Apr 19, 2020
@phunkyfish phunkyfish added this to the Matrix 19.0-alpha 1 milestone Apr 19, 2020
@matthuisman matthuisman deleted the windows_build_docs branch April 20, 2020 02:53
@matthuisman matthuisman restored the windows_build_docs branch April 20, 2020 02:53
@matthuisman
Copy link
Contributor Author

ooops, deleted this branch by accident but then restored

@matthuisman matthuisman reopened this Apr 20, 2020
@phunkyfish phunkyfish requested a review from Paxxi April 20, 2020 09:12
Copy link
Member

@Paxxi Paxxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the comment. If that is tested then go ahead and merge.

Thanks @matthuisman 😀

docs/README.Windows.md Outdated Show resolved Hide resolved
@Paxxi
Copy link
Member

Paxxi commented Apr 22, 2020

Did you close this by accident again @matthuisman ?

@phunkyfish phunkyfish reopened this Apr 22, 2020
@phunkyfish
Copy link
Contributor

I’m going to assume a yes 😉

docs/README.Windows.md Outdated Show resolved Hide resolved
@matthuisman
Copy link
Contributor Author

matthuisman commented Apr 22, 2020

After the comments - i wasnt actually sure if those arm libraries where needed or not.
So maybe we just keep them as is.

I never even opened VS. I just followed the build commands and did it in command prompt.
There isn't anything there about using the .sln to build (also nothing about binary addons?)

All I know at moment is I didn't need them for the below to make a working kodi.exe
cmake -G "Visual Studio 15 Win64" -T host=x64 %userprofile%\kodi
cmake --build . --config "Release"

I'll try run a BuildSetup.bat now without them and see if that completes
Nope, Unresolved external symbol dav1d_picture_unref referenced in function libdav1d

What else is interesting, when I did my first build of kodi.exe and copied into nightly directory, the nightly didn't have libdvdnav.dll (needed to copy that over). So not sure what is happening there.

Also, the docs make it sound like the kodi.exe should just run in it's own folder.
But it doesn't - just a bunch of missing dlls.
So maybe more of a docs overhaul needed

Should I update this PR to remove the (if compiling for ARM) notes?

@Paxxi
Copy link
Member

Paxxi commented Apr 23, 2020

I think either remove it or add the suggestions I made to change it to (if not compiling arm or uwp). You should be able to accept the edits right on the page under the changes tab.

You don't have to test it, I tested it myself yesterday

matthuisman and others added 2 commits April 23, 2020 17:06
Co-Authored-By: Pär Björklund <per.bjorklund@gmail.com>
Co-Authored-By: Pär Björklund <per.bjorklund@gmail.com>
@matthuisman
Copy link
Contributor Author

done :)

@Paxxi Paxxi merged commit bd2f999 into xbmc:master Apr 23, 2020
@Paxxi
Copy link
Member

Paxxi commented Apr 23, 2020

Thanks again 😀

Maven85 pushed a commit to Maven85/kodi that referenced this pull request Apr 23, 2020
Update Windows build readme to match current VS2017 and java installers
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
Update Windows build readme to match current VS2017 and java installers
@matthuisman matthuisman deleted the windows_build_docs branch May 7, 2020 09:25
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
Update Windows build readme to match current VS2017 and java installers
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
Update Windows build readme to match current VS2017 and java installers
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
Update Windows build readme to match current VS2017 and java installers
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
Update Windows build readme to match current VS2017 and java installers
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
Update Windows build readme to match current VS2017 and java installers
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Update Windows build readme to match current VS2017 and java installers
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Update Windows build readme to match current VS2017 and java installers
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Update Windows build readme to match current VS2017 and java installers
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
Update Windows build readme to match current VS2017 and java installers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants