Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repository.xbmc.org] Define assets and bump addon version #17704

Merged
merged 1 commit into from Apr 20, 2020

Conversation

enen92
Copy link
Member

@enen92 enen92 commented Apr 19, 2020

Description

Matrix no longer supports the old fallback for the icon in the root directory of addons. Now (since krypton) it requires the <assets> element to be defined in addon.xml. This PR does it for the xbmc repo addon (plus bumping the addon version).

Motivation and Context

Fix icon not showing in the Kodi UI for any repo references

How Has This Been Tested?

Runtime

Screenshots (if appropriate):

Master
master

PR
pr

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@enen92 enen92 added Type: Fix non-breaking change which fixes an issue v19 Matrix labels Apr 19, 2020
@enen92 enen92 added this to the Matrix 19.0-alpha 1 milestone Apr 19, 2020
@enen92 enen92 requested a review from ronie April 19, 2020 21:19
Copy link
Member

@ronie ronie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thx!

@enen92 enen92 merged commit 758f3bf into xbmc:master Apr 20, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Apr 20, 2020
[repository.xbmc.org] Define assets and bump addon version
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
[repository.xbmc.org] Define assets and bump addon version
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
[repository.xbmc.org] Define assets and bump addon version
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
[repository.xbmc.org] Define assets and bump addon version
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
[repository.xbmc.org] Define assets and bump addon version
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
[repository.xbmc.org] Define assets and bump addon version
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
[repository.xbmc.org] Define assets and bump addon version
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[repository.xbmc.org] Define assets and bump addon version
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[repository.xbmc.org] Define assets and bump addon version
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[repository.xbmc.org] Define assets and bump addon version
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
[repository.xbmc.org] Define assets and bump addon version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants