Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CurlFile] proper setup proxy credentials #17711

Merged
merged 1 commit into from Apr 21, 2020
Merged

[CurlFile] proper setup proxy credentials #17711

merged 1 commit into from Apr 21, 2020

Conversation

howie-f
Copy link
Contributor

@howie-f howie-f commented Apr 20, 2020

Description

follow up to #17338

this sets proxy credentials up with curl encoding only if username and password are set

How Has This Been Tested?

build passed

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)

Checklist:

@phunkyfish

howie-f
howie-f commented Apr 20, 2020
View reviewed changes
xbmc/filesystem/CurlFile.cpp Outdated Show resolved Hide resolved
phunkyfish
phunkyfish requested changes Apr 20, 2020
View reviewed changes
xbmc/filesystem/CurlFile.cpp Outdated Show resolved Hide resolved
xbmc/filesystem/CurlFile.cpp Outdated Show resolved Hide resolved
phunkyfish
phunkyfish requested changes Apr 20, 2020
View reviewed changes
xbmc/filesystem/CurlFile.cpp Outdated Show resolved Hide resolved
@howie-f
Copy link
Contributor Author

howie-f commented Apr 20, 2020

suggestions applied

@phunkyfish phunkyfish added Type: Improvement non-breaking change which improves existing functionality v19 Matrix Component: Network labels Apr 20, 2020
@phunkyfish phunkyfish added this to the Matrix 19.0-alpha 1 milestone Apr 20, 2020
@phunkyfish phunkyfish added the Type: Fix non-breaking change which fixes an issue label Apr 20, 2020
@phunkyfish
Copy link
Contributor

jenkins build this please

phunkyfish
phunkyfish approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Now we just have to wait for Jenkins to be happy.

@phunkyfish
Copy link
Contributor

phunkyfish commented Apr 20, 2020 •
edited

Once this gets merged then we can do the backport.

@howie-f
Copy link
Contributor Author

howie-f commented Apr 20, 2020

ok, will get it ready

@phunkyfish
Copy link
Contributor

Thanks @howie-f you can create the backport PR when ready.

@phunkyfish phunkyfish merged commit 8c7a0fe into xbmc:master Apr 21, 2020
@howie-f howie-f mentioned this pull request Apr 21, 2020
Merged
2 tasks
@howie-f howie-f deleted the v19-proxycredentials branch April 21, 2020 07:50
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Apr 22, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17711 from howie-f/v19-proxycredentials
a9e99f6 
[CurlFile] proper setup proxy credentials
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17711 from howie-f/v19-proxycredentials
bceaad6 
[CurlFile] proper setup proxy credentials
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17711 from howie-f/v19-proxycredentials
e63f797 
[CurlFile] proper setup proxy credentials
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17711 from howie-f/v19-proxycredentials
9b1b538 
[CurlFile] proper setup proxy credentials
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17711 from howie-f/v19-proxycredentials
42de37e 
[CurlFile] proper setup proxy credentials
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17711 from howie-f/v19-proxycredentials
e9a9f0b 
[CurlFile] proper setup proxy credentials
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17711 from howie-f/v19-proxycredentials
52b8252 
[CurlFile] proper setup proxy credentials
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17711 from howie-f/v19-proxycredentials
10ef116 
[CurlFile] proper setup proxy credentials
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17711 from howie-f/v19-proxycredentials
c847bb0 
[CurlFile] proper setup proxy credentials
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17711 from howie-f/v19-proxycredentials
d0e1e44 
[CurlFile] proper setup proxy credentials
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
@phunkyfish @Maven85
Merge pull request xbmc#17711 from howie-f/v19-proxycredentials
781ce9d 
[CurlFile] proper setup proxy credentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phunkyfish phunkyfish phunkyfish approved these changes

Assignees
No one assigned
Labels
Backport: Done Component: Network Type: Fix non-breaking change which fixes an issue Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-alpha 1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@howie-f @phunkyfish