Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inputstream] support mime type by default for all inputstream addons #17727

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

phunkyfish
Copy link
Contributor

Description

Mime type if available will be sent to inputstream addons.

Motivation and Context

Otherwise each inpustream addon needs to implement its own property for this purpose.

How Has This Been Tested?

OSX using inputstream.ffmpegdirect

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@phunkyfish phunkyfish added Type: Feature non-breaking change which adds functionality API change: Binary add-ons v19 Matrix labels Apr 22, 2020
@phunkyfish phunkyfish added this to the Matrix 19.0-alpha 1 milestone Apr 22, 2020
Copy link
Member

@AlwinEsch AlwinEsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this makes sense and is OK to add.

@phunkyfish phunkyfish merged commit b2ff111 into xbmc:master Apr 23, 2020
@phunkyfish phunkyfish deleted the input-mime-type branch April 23, 2020 08:03
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Apr 23, 2020
[inputstream] support mime type by default for all inputstream addons
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
[inputstream] support mime type by default for all inputstream addons
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
[inputstream] support mime type by default for all inputstream addons
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
[inputstream] support mime type by default for all inputstream addons
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
[inputstream] support mime type by default for all inputstream addons
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
[inputstream] support mime type by default for all inputstream addons
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
[inputstream] support mime type by default for all inputstream addons
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[inputstream] support mime type by default for all inputstream addons
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[inputstream] support mime type by default for all inputstream addons
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[inputstream] support mime type by default for all inputstream addons
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
[inputstream] support mime type by default for all inputstream addons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change: Binary add-ons Type: Feature non-breaking change which adds functionality v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants