Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[pvr] add missing channel up/down key bindings in remaining keymap files #1773

Merged
merged 1 commit into from Nov 15, 2012

Conversation

Projects
None yet
4 participants
Member

da-anda commented Nov 13, 2012

This PR adds the key binding for channel up/down in FullscreenLiveTV to the rest of the shipped keymap files after 108c19c. Note that was not able to test any of those keymaps (that's why they where not part of the initial PR) but I gave my best to find proper mappings for each controller.

Member

da-anda commented Nov 13, 2012

sorry for git mail spam, but could someone have a look / proof read / test that the suggested bindings are fine? I don't have any of those input devices (at least not connected with a XBMC setup) We should at least get the remote.xml in for BETA in order to make all the CEC users ( @opdenkamp, @n37 ) happy

Member

jmarshallnz commented Nov 13, 2012

By the looks of it you've copied across the previous buttons that were mapped to the bigskip/skip stuff, which is the correct thing to do. Whether or not the bindings are fine probably hasn't been tested all that much on some of the gamepad ones, but your change is consistent with how it was when PVR was merged.

I've started a forum thread at http://forum.xbmc.org/showthread.php?tid=145145 to discuss more about remote behavior for Live TV. My main concern with the current approach is that the up, down, left, right are typically using for skipping. Any user with a PVR addon that supports time shifting is going to need to change the remote mapping for their device if they want to make use of that functionality.

I also wonder whether the navigation to the different channel groups should be done after the PVR display of on screen channels is displayed. That could leave left and right for the small skip backward and forward and only the big skip forward and backward would be lost to channel up and down. I'm not sure what the penetration of channel groups will be. We don't use channel groups but I suspect a lot probably would.

Member

da-anda commented Nov 14, 2012

as stated in the forum thread, the aim of this PR is to bring back the already known and previously hardcoded behavior before 108c19c - so it's more a bugfix for functionality loss. While I agree that current/old mapping is not the best idea now that most PVR backends have timeshift support (which I already expressed earlier on the forum), it's not the aim of this PR to add changed behavior nor implement still missing keymaps for other PVR sections that are currently only mapped in keyboard.xml. So changing default behavior is IMO a task for a different PR.

Member

opdenkamp commented Nov 14, 2012

not every CEC device supports channel up/down key presses, so it must be put back in remote.xml at least. for some input methods that always have dedicated channel up/down actions, it doesn't have to be put back. but I'd like to have this at least in keyboard and remote xmls

Member

da-anda commented Nov 15, 2012

so what to do now? We should find a solution for beta2.
Another thing that bothers me is that a user posted on the forum that the >FullscreenLiveTV< tag/mapping is not working for his AppleRemote when he adds it manually. But I don't see what's missing in my FullscreenLiveTV window implementation that might be causing this :(

Member

jmarshallnz commented Nov 15, 2012

Don't worry about the forum user - they could have screwed it up. There's nothing platform-specific about your changes.

I suggest either this is merged as-is, or a consensus on a changed default mapping is reached and that is then implemented.

Member

opdenkamp commented Nov 15, 2012

right, let's merge this one as-is, and change mappings afterwards if something comes out of the forum topic.

opdenkamp pushed a commit that referenced this pull request Nov 15, 2012

Merge pull request #1773 from da-anda/pvr-keymap-2
[pvr] add missing channel up/down key bindings in remaining keymap files

@opdenkamp opdenkamp merged commit d9eb915 into xbmc:master Nov 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment