[pvr] add missing channel up/down key bindings in remaining keymap files

[da-anda]

This PR adds the key binding for channel up/down in FullscreenLiveTV to the rest of the shipped keymap files after 108c19c. Note that was not able to test any of those keymaps (that's why they where not part of the initial PR) but I gave my best to find proper mappings for each controller.

[da-anda]

sorry for git mail spam, but could someone have a look / proof read / test that the suggested bindings are fine? I don't have any of those input devices (at least not connected with a XBMC setup) We should at least get the remote.xml in for BETA in order to make all the CEC users ( @opdenkamp, @n37 ) happy

[jmarshallnz]

By the looks of it you've copied across the previous buttons that were mapped to the bigskip/skip stuff, which is the correct thing to do. Whether or not the bindings are fine probably hasn't been tested all that much on some of the gamepad ones, but your change is consistent with how it was when PVR was merged.

[da-anda]

as stated in the forum thread, the aim of this PR is to bring back the already known and previously hardcoded behavior before 108c19c - so it's more a bugfix for functionality loss. While I agree that current/old mapping is not the best idea now that most PVR backends have timeshift support (which I already expressed earlier on the forum), it's not the aim of this PR to add changed behavior nor implement still missing keymaps for other PVR sections that are currently only mapped in keyboard.xml. So changing default behavior is IMO a task for a different PR.

[opdenkamp]

not every CEC device supports channel up/down key presses, so it must be put back in remote.xml at least. for some input methods that always have dedicated channel up/down actions, it doesn't have to be put back. but I'd like to have this at least in keyboard and remote xmls

[da-anda]

so what to do now? We should find a solution for beta2.
Another thing that bothers me is that a user posted on the forum that the >FullscreenLiveTV< tag/mapping is not working for his AppleRemote when he adds it manually. But I don't see what's missing in my FullscreenLiveTV window implementation that might be causing this :(

[jmarshallnz]

Don't worry about the forum user - they could have screwed it up. There's nothing platform-specific about your changes.

I suggest either this is merged as-is, or a consensus on a changed default mapping is reached and that is then implemented.

[opdenkamp]

right, let's merge this one as-is, and change mappings afterwards if something comes out of the forum topic.