Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

[pvr] add missing channel up/down key bindings in remaining keymap files #1773

Merged
merged 1 commit into from

4 participants

@da-anda
Collaborator

This PR adds the key binding for channel up/down in FullscreenLiveTV to the rest of the shipped keymap files after 108c19c. Note that was not able to test any of those keymaps (that's why they where not part of the initial PR) but I gave my best to find proper mappings for each controller.

@da-anda
Collaborator

sorry for git mail spam, but could someone have a look / proof read / test that the suggested bindings are fine? I don't have any of those input devices (at least not connected with a XBMC setup) We should at least get the remote.xml in for BETA in order to make all the CEC users ( @opdenkamp, @n37 ) happy

@jmarshallnz
Owner

By the looks of it you've copied across the previous buttons that were mapped to the bigskip/skip stuff, which is the correct thing to do. Whether or not the bindings are fine probably hasn't been tested all that much on some of the gamepad ones, but your change is consistent with how it was when PVR was merged.

@dteirney
Collaborator

I've started a forum thread at http://forum.xbmc.org/showthread.php?tid=145145 to discuss more about remote behavior for Live TV. My main concern with the current approach is that the up, down, left, right are typically using for skipping. Any user with a PVR addon that supports time shifting is going to need to change the remote mapping for their device if they want to make use of that functionality.

I also wonder whether the navigation to the different channel groups should be done after the PVR display of on screen channels is displayed. That could leave left and right for the small skip backward and forward and only the big skip forward and backward would be lost to channel up and down. I'm not sure what the penetration of channel groups will be. We don't use channel groups but I suspect a lot probably would.

@da-anda
Collaborator

as stated in the forum thread, the aim of this PR is to bring back the already known and previously hardcoded behavior before 108c19c - so it's more a bugfix for functionality loss. While I agree that current/old mapping is not the best idea now that most PVR backends have timeshift support (which I already expressed earlier on the forum), it's not the aim of this PR to add changed behavior nor implement still missing keymaps for other PVR sections that are currently only mapped in keyboard.xml. So changing default behavior is IMO a task for a different PR.

@opdenkamp
Collaborator

not every CEC device supports channel up/down key presses, so it must be put back in remote.xml at least. for some input methods that always have dedicated channel up/down actions, it doesn't have to be put back. but I'd like to have this at least in keyboard and remote xmls

@da-anda
Collaborator

so what to do now? We should find a solution for beta2.
Another thing that bothers me is that a user posted on the forum that the >FullscreenLiveTV< tag/mapping is not working for his AppleRemote when he adds it manually. But I don't see what's missing in my FullscreenLiveTV window implementation that might be causing this :(

@jmarshallnz
Owner

Don't worry about the forum user - they could have screwed it up. There's nothing platform-specific about your changes.

I suggest either this is merged as-is, or a consensus on a changed default mapping is reached and that is then implemented.

@opdenkamp
Collaborator

right, let's merge this one as-is, and change mappings afterwards if something comes out of the forum topic.

@opdenkamp opdenkamp merged commit d9eb915 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 13, 2012
  1. [pvr] add missing channel up/down key bindings in FullScreenLiveTV fo…

    Franz Koch authored
    …r remaining keymap files after 108c19c
This page is out of date. Refresh to see the latest.
View
8 system/keymaps/gamepad.xml
@@ -109,6 +109,14 @@
<dpaddown>BigStepBack</dpaddown>
</gamepad>
</FullscreenVideo>
+ <FullscreenLiveTV>
+ <gamepad>
+ <dpadleft>PreviousChannelGroup</dpadleft>
+ <dpadright>NextChannelGroup</dpadright>
+ <dpadup>ChannelUp</dpadup>
+ <dpaddown>ChannelDown</dpaddown>
+ </gamepad>
+ </FullscreenLiveTV>
<FullscreenInfo>
<gamepad>
<start>OSD</start>
View
8 system/keymaps/joystick.AppleRemote.xml
@@ -111,6 +111,14 @@
<!-- FlickDown --> <button id="88">BigStepBack</button>
</joystick>
</FullscreenVideo>
+ <FullscreenLiveTV>
+ <joystick name="AppleRemote">
+ <button id="3">ChannelDown</button>
+ <button id="4">ChannelUp</button>
+ <!-- pageup --> <button id="13">ChannelUp</button>
+ <!-- pagedown --> <button id="14">ChannelDown</button>
+ </joystick>
+ </FullscreenLiveTV>
<Visualisation>
<joystick name="AppleRemote">
<button id="1">VolumeUp</button>
View
8 system/keymaps/joystick.Harmony.xml
@@ -172,6 +172,14 @@
<!-- F6 --> <button id="94">ShowSubtitles</button>
</joystick>
</FullscreenVideo>
+ <FullscreenLiveTV>
+ <joystick name="Harmony">
+ <!-- up --> <button id="1">ChannelUp</button>
+ <!-- down --> <button id="2">ChannelDown</button>
+ <!-- left --> <button id="3">PreviousChannelGroup</button>
+ <!-- right --> <button id="4">NextChannelGroup</button>
+ </joystick>
+ </FullscreenLiveTV>
<FullscreenInfo>
<joystick name="Harmony">
<!-- Info --> <button id="31">Back</button>
View
10 system/keymaps/joystick.Logitech.RumblePad.2.xml
@@ -63,6 +63,16 @@
</joystick>
</FullscreenVideo>
+ <FullscreenLiveTV>
+ <joystick name="Logitech Logitech Cordless RumblePad 2">
+ <altname>Logitech Cordless RumblePad 2</altname>
+ <hat id="1" position="left">PreviousChannelGroup</hat>
+ <hat id="1" position="right">NextChannelGroup</hat>
+ <hat id="1" position="up">ChannelUp</hat>
+ <hat id="1" position="down">ChannelDown</hat>
+ </joystick>
+ </FullscreenLiveTV>
+
<Visualisation>
<joystick name="Logitech Logitech Cordless RumblePad 2">
<altname>Logitech Cordless RumblePad 2</altname>
View
18 system/keymaps/joystick.Microsoft.Xbox.360.Controller.xml
@@ -175,6 +175,22 @@
<axis limit="0" id="6">AnalogFastForward</axis>
</joystick>
</FullscreenVideo>
+ <FullscreenLiveTV>
+ <joystick name="Xbox 360 Wireless Receiver">
+ <altname>Controller (Gamepad for Xbox 360)</altname>
+ <altname>Controller (XBOX 360 For Windows)</altname>
+ <altname>Controller (Xbox 360 Wireless Receiver for Windows)</altname>
+ <altname>Controller (Xbox wireless receiver for windows)</altname>
+ <altname>XBOX 360 For Windows (Controller)</altname>
+ <altname>XBOX 360 For Windows</altname>
+ <altname>Xbox Receiver for Windows (Wireless Controller)</altname>
+ <altname>Xbox wireless receiver for windows (Controller)</altname>
+ <button id="11">ChannelUp</button>
+ <button id="12">ChannelDown</button>
+ <button id="13">PreviousChannelGroup</button>
+ <button id="14">NextChannelGroup</button>
+ </joystick>
+ </FullscreenLiveTV>
<FullscreenInfo>
<joystick name="Xbox 360 Wireless Receiver">
<altname>Controller (Gamepad for Xbox 360)</altname>
@@ -530,4 +546,4 @@
<button id="2">Back</button>
</joystick>
</ProfileSettings>
-</keymap>
+</keymap>
View
11 system/keymaps/joystick.Microsoft.Xbox.Controller.S.xml
@@ -128,6 +128,17 @@
<axis limit="0" id="6">AnalogFastForward</axis>
</joystick>
</FullscreenVideo>
+ <FullscreenLiveTV>
+ <joystick name="Microsoft Xbox Controller S">
+ <altname>Mad Catz MicroCON</altname>
+ <altname>Logitech Xbox Cordless Controller</altname>
+ <altname>Microsoft X-Box pad (Japan)</altname>
+ <button id="13">ChannelUp</button>
+ <button id="14">NextChannelGroup</button>
+ <button id="15">ChannelDown</button>
+ <button id="16">PreviousChannelGroup</button>
+ </joystick>
+ </FullscreenLiveTV>
<FullscreenInfo>
<joystick name="Microsoft Xbox Controller S">
<altname>Mad Catz MicroCON</altname>
View
11 system/keymaps/joystick.PS3.Remote.Keyboard.xml
@@ -101,7 +101,16 @@
<hat id="1" position="down">BigStepBack</hat>
</joystick>
</FullscreenVideo>
-
+
+ <FullscreenLiveTV>
+ <joystick name="PLAYSTATION(R)3 Remote Keyboard">
+ <hat id="1" position="left">PreviousChannelGroup</hat>
+ <hat id="1" position="right">NextChannelGroup</hat>
+ <hat id="1" position="up">ChannelUp</hat>
+ <hat id="1" position="down">ChannelDown</hat>
+ </joystick>
+ </FullscreenLiveTV>
+
<VideoOSD>
<joystick name="PLAYSTATION(R)3 Remote Keyboard">
<altname>PS3 Remote Keyboard</altname>
View
6 system/keymaps/joystick.WiiRemote.xml
@@ -100,6 +100,12 @@
<button id="11">AspectRatio</button>
</joystick>
</FullscreenVideo>
+ <FullscreenLiveTV>
+ <joystick name="WiiRemote">
+ <button id="3">ChannelDown</button>
+ <button id="4">ChannelUp</button>
+ </joystick>
+ </FullscreenLiveTV>
<FullscreenInfo>
<joystick name="WiiRemote">
<button id="5">CodecInfo</button>
View
8 system/keymaps/remote.xml
@@ -508,6 +508,14 @@
<back>Close</back>
</remote>
</Favourites>
+ <FullscreenLiveTV>
+ <remote>
+ <left>PreviousChannelGroup</left>
+ <right>NextChannelGroup</right>
+ <up>ChannelUp</up>
+ <down>ChannelDown</down>
+ </remote>
+ </FullscreenLiveTV>
<PVROSDChannels>
<remote>
<back>Close</back>
Something went wrong with that request. Please try again.