windowing/gbm: preseve crtc index when adding crtcs #17736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrusak
added
Type: Fix
sigmaris
reviewed
Apr 25, 2020
lrusak
force-pushed
the
drm-fix-crtc-index
branch
from
fae5a78
to
c130ad4
Compare
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 29, 2020
windowing/gbm: preseve crtc index when adding crtcs
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 29, 2020
windowing/gbm: preseve crtc index when adding crtcs
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
May 5, 2020
windowing/gbm: preseve crtc index when adding crtcs
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 3, 2020
windowing/gbm: preseve crtc index when adding crtcs
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
windowing/gbm: preseve crtc index when adding crtcs
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
windowing/gbm: preseve crtc index when adding crtcs
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
windowing/gbm: preseve crtc index when adding crtcs
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
windowing/gbm: preseve crtc index when adding crtcs
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
windowing/gbm: preseve crtc index when adding crtcs
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
windowing/gbm: preseve crtc index when adding crtcs
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
windowing/gbm: preseve crtc index when adding crtcs
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 7, 2020
windowing/gbm: preseve crtc index when adding crtcs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced in #16237
The crtc index needs to be preserved to allow properly checking planes against possible_crtcs
This preserves the crtc index even when the crtc isn't desired.
We got lucky before because all the systems we tested on must of had the desired crtc as index 0. When testing on the raspberry pi the desired crtc is at index 2 so when we threw away the invalid crtcs the index became invalid also.
Thanks @MilhouseVH for catching this.
@sigmaris can you test to make sure this still works on your platform with this change?