Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][python] Improve documentation for xbmcdrm #17741

Merged
merged 1 commit into from Apr 24, 2020

Conversation

CastagnaIT
Copy link
Collaborator

Description

As requested from @enen92 i have tried to help to improve the documentation of this module which was too dry

Motivation and Context

Improve docu and facilitate integration

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Some of the lines could be a bit smaller (broken into several lines) but it's more than fine for me.
Thanks again

@enen92
Copy link
Member

enen92 commented Apr 24, 2020

jenkins build this please

Copy link
Contributor

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads well to a native english speaker. Well done ;)

@enen92 enen92 merged commit 35641ba into xbmc:master Apr 24, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Apr 27, 2020
[docs][python] Improve documentation for xbmcdrm
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
[docs][python] Improve documentation for xbmcdrm
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
[docs][python] Improve documentation for xbmcdrm
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
[docs][python] Improve documentation for xbmcdrm
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
[docs][python] Improve documentation for xbmcdrm
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
[docs][python] Improve documentation for xbmcdrm
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
[docs][python] Improve documentation for xbmcdrm
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[docs][python] Improve documentation for xbmcdrm
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[docs][python] Improve documentation for xbmcdrm
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[docs][python] Improve documentation for xbmcdrm
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
[docs][python] Improve documentation for xbmcdrm
@CastagnaIT CastagnaIT deleted the drm_docu branch October 6, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants