Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] drop xbmc.abortRequested flag #17789

Merged
merged 1 commit into from
May 13, 2020
Merged

Conversation

enen92
Copy link
Member

@enen92 enen92 commented Apr 30, 2020

Description

This PR removes the long deprecated (at least since xbmc.Monitor().abortRequested()) was introduced xbmc.abortRequested flag. This method is not documented in the API since the migration to doxygen/codedocs. In fact I suspect some of the errors seen in #17705 are in fact false positives caused by this old mechanism.

@MilhouseVH I'd probably recommend to include this in your builds and wait ~ a week to see if any regression shows.

Motivation and Context

Cleanup, encourage to use the monitor method instead

How Has This Been Tested?

Tested netflix, tubecast, flask-webinterface-demo addon, and kodi aborts correctly

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@enen92 enen92 added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality API change: Python v19 Matrix labels Apr 30, 2020
@enen92 enen92 added this to the Matrix 19.0-alpha 1 milestone Apr 30, 2020
@MilhouseVH
Copy link
Contributor

I can see we're going to need to make changes to the LibreELEC Settings add-on once this PR is added, I'll try and make those changes today and then begin testing this, so hopefully in #0430.

Copy link
Contributor

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@phunkyfish
Copy link
Contributor

@MilhouseVH Can this go in?

@MilhouseVH
Copy link
Contributor

@MilhouseVH Can this go in?

I think so, yes.

@enen92 enen92 merged commit b31eccc into xbmc:master May 13, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[python] drop xbmc.abortRequested flag
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[python] drop xbmc.abortRequested flag
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[python] drop xbmc.abortRequested flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change: Python Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants