add 'CVideoDatabase::GetPreviousEpisodeNotWatched' function #1780

Closed
wants to merge 1 commit into from

3 participants

@ikkemaniac

add check for unwatched episodes hooked in the 'OnPlayMedia' function
to inform the user of unwatched episodes from earlier this or previous
seasons.

wrote this for myself, maybe you find it usefull.

Regards,

ikkemaniac add 'CVideoDatabase::GetPreviousEpisodeNotWatched' function
add check for unwatched episodes hooked in the 'OnPlayMedia' function
to inform the user of unwatched episodes from earlier this or previous
seasons.
74e04ae
@jmarshallnz
Team Kodi member

I'm not sure whether we'll take the feature, but in general, please follow XBMC code guidelines ( braces on separate lines, make sure indenting is spaces using 2 spaces). Also, make sure you don't have extraneous comments or extraneous log statements in your patch.

Lastly, please feel free to use multi-line select statements instead of insanely long lines.

Your implementation seems reasonable, though I'd copy the item rather than just the path when you transform, and also eliminate the CFileItemPtr typedef in VideoDatabase.h by just passing a const CFileItem &.

This will be discussed post Frodo, so no need to make any changes should you not have the time etc.

@ikkemaniac

Ok, let me know if there's intrest, I will fix all suggestions then.

@MartijnKaijser
Team Kodi member

@jmarshallnz
is this something we will take?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment