Revert "[Backport][Android] pause audio playback when headphone is disconnected" #17868
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 46d79a9.
from the PR here: #17541
which is a backport of this PR: #17030
This commit is causing Kodi to pause playback on frame-rate switches after content is playing (late switch)
Discussion here
xbmc/inputstream.adaptive#440 (comment)
Confirmed fix here:
xbmc/inputstream.adaptive#440 (comment)
https://www.kodinerds.net/index.php/Thread/67624-Disney-Addon/?postID=590508#post590508
To reproduce the issue - use either Leia or Matrix nightly on Android.
Set frame-rate switch time to 6 seconds.
Play content with different frame-rate - observe kodi pauses after the framerate switch
You can also get same behaviour when content is playing, going into kodi settings and changing frame-rate
Test builds with this commit reverted
ARM:
https://jenkins.kodi.tv/job/Android-ARM/18067/artifact/kodi-20200514-ee2959ce-PR17868-merge-armeabi-v7a.apk
ARM64:
https://jenkins.kodi.tv/job/Android-ARM64/14703/artifact/kodi-20200514-ee2959ce-PR17868-merge-arm64-v8a.apk
Should I also do PR to revert the Matrix commit?
Or leave it and give the author a chance to update?
18.7 is close - so think it's safer to remove from Leia
Description
Motivation and Context
How Has This Been Tested?
Kodi 18.7 built without the commit tested vs Kodi 18.7 with the commit by user on Nvidia shield.
Confirmed using the build without the commit (and also Kodi 18.6) that the issue does not happen
Screenshots (if appropriate):
Types of change
Checklist: