Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event server keyboard events dont work for keys that have long press defined #18045

Merged
merged 1 commit into from Jul 15, 2020
Merged

Event server keyboard events dont work for keys that have long press defined #18045

merged 1 commit into from Jul 15, 2020

Conversation

mglae
Copy link
Contributor

@mglae mglae commented Jun 11, 2020

Description

Backport of #17806

Motivation and Context

Fix it in Leia.

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

garbear
garbear approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@garbear garbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phunkyfish any problem reports from Matrix?

@phunkyfish
Copy link
Contributor

No, not that I have seen.

@phunkyfish phunkyfish added this to the Leia 18.8 milestone Jun 16, 2020
@DaveTBlake DaveTBlake added the Type: Fix non-breaking change which fixes an issue label Jul 15, 2020
@DaveTBlake DaveTBlake merged commit 439cd8c into xbmc:Leia Jul 15, 2020
@mglae mglae deleted the leia_event-server-keyboard-longpress-keys branch July 15, 2020 16:19
DaveTBlake added a commit to DaveTBlake/xbmc that referenced this pull request Oct 20, 2020
@DaveTBlake
Fix event server unable to send raw key strikes after xbmc#18045
1945b57
@DaveTBlake DaveTBlake mentioned this pull request Oct 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbear garbear garbear approved these changes

Assignees
No one assigned
Labels
Type: Backport Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Milestone
Leia 18.8
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mglae @phunkyfish @garbear @DaveTBlake @HenrikJohnson