New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artist discography - Use Musicbrainz releasegroup ids for matching #18079
Conversation
This has been tested in conjunction with scrapers that set release group mbid for discography entries: Used a library with albums with and without mbid values, on artists with discography entries that are not unique by name, and with some of them in the library as albums etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the current code guidelines.
…cbrainz release group id (providing scraper provides it)
ed05b01
to
38ec53e
Compare
Artist discography - Use Musicbrainz releasegroup ids for matching
Artist discography - Use Musicbrainz releasegroup ids for matching
Artist discography - Use Musicbrainz releasegroup ids for matching
Artist discography - Use Musicbrainz releasegroup ids for matching
Artist discography - Use Musicbrainz releasegroup ids for matching
Artist discography - Use Musicbrainz releasegroup ids for matching
Artist discography - Use Musicbrainz releasegroup ids for matching
Artist discography - Use Musicbrainz releasegroup ids for matching
Artist discography - Use Musicbrainz releasegroup ids for matching
Artist discography - Use Musicbrainz releasegroup ids for matching
Artist discography - Use Musicbrainz releasegroup ids for matching
Artist discography - Use Musicbrainz releasegroup ids for matching
Improve artist discography matching to albums in users music library by using Musicbrainz release group id when the artist scraper provides it.
Bump music db to v79 for change to discography table
Sometimes artist and album title are not enough to uniquely identify an album e.g. there are 5 different albums (with totally different tracks) by Peter Gabriel called "Peter Gabriel". In Musicbrainz these are referenced different release groups, and collectors that have name duplicate albums like these can add them all to their music library providing that they tag the music files with mbid tags.
However the artist discography facility - a scraped list of albums by the artist independant of what albums the user has in their library - was not able to handle these name duplicates when matching them to those that where in the library. This PR fixes that.