Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artist discography - Use Musicbrainz releasegroup ids for matching #18079

Merged
merged 1 commit into from Jun 28, 2020

Conversation

DaveTBlake
Copy link
Member

Improve artist discography matching to albums in users music library by using Musicbrainz release group id when the artist scraper provides it.

Bump music db to v79 for change to discography table


Sometimes artist and album title are not enough to uniquely identify an album e.g. there are 5 different albums (with totally different tracks) by Peter Gabriel called "Peter Gabriel". In Musicbrainz these are referenced different release groups, and collectors that have name duplicate albums like these can add them all to their music library providing that they tag the music files with mbid tags.

However the artist discography facility - a scraped list of albums by the artist independant of what albums the user has in their library - was not able to handle these name duplicates when matching them to those that where in the library. This PR fixes that.

@DaveTBlake DaveTBlake added Type: Improvement non-breaking change which improves existing functionality Component: Music v19 Matrix labels Jun 20, 2020
@DaveTBlake DaveTBlake added this to the Matrix 19.0-alpha 1 milestone Jun 20, 2020
@DaveTBlake
Copy link
Member Author

This has been tested in conjunction with scrapers that set release group mbid for discography entries:
xml scraper Universal Artist Scraper v4.3.3 and updated dependency MB common scraper v2.2.4
and a development version of the Python scraper Generic Artists Scraper v 1.0.6

Used a library with albums with and without mbid values, on artists with discography entries that are not unique by name, and with some of them in the library as albums etc.

Copy link
Member

@Rechi Rechi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the current code guidelines.

xbmc/music/Artist.cpp Outdated Show resolved Hide resolved
xbmc/music/MusicDatabase.h Outdated Show resolved Hide resolved
…cbrainz release group id (providing scraper provides it)
@DaveTBlake DaveTBlake merged commit 7493cd9 into xbmc:master Jun 28, 2020
@DaveTBlake DaveTBlake deleted the DiscoWithMbid branch June 28, 2020 13:51
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jun 29, 2020
Artist discography  - Use  Musicbrainz releasegroup ids for matching
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
Artist discography  - Use  Musicbrainz releasegroup ids for matching
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
Artist discography  - Use  Musicbrainz releasegroup ids for matching
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
Artist discography  - Use  Musicbrainz releasegroup ids for matching
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
Artist discography  - Use  Musicbrainz releasegroup ids for matching
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
Artist discography  - Use  Musicbrainz releasegroup ids for matching
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Artist discography  - Use  Musicbrainz releasegroup ids for matching
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Artist discography  - Use  Musicbrainz releasegroup ids for matching
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Artist discography  - Use  Musicbrainz releasegroup ids for matching
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Artist discography  - Use  Musicbrainz releasegroup ids for matching
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
Artist discography  - Use  Musicbrainz releasegroup ids for matching
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 8, 2020
Artist discography  - Use  Musicbrainz releasegroup ids for matching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Music Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants