[addons] Show both enabled and disabled incompatbile addons when performing a migration

[phunkyfish]

Description

Follow on from #18087

As incompatible addons are now disabled with a reason these would have been missing from the incompatible list when migrating and the user would not be shown which addons would be disabled.

Motivation and Context

To make it clear to users which addons will be disabled.

How Has This Been Tested?

Still needs to be tested.

Screenshots (if appropriate):

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[AlwinEsch]

From first view it looks good and hope to have time for test the next days.

[Dnkhatri]

I know this is off topic but would it be possible to get what addons will work with v19 before installing it. On android its not possible to install both kodi versions side by side so installing v19 means we cant go back to v18 if some addons are not available.

[phunkyfish]

I know this is off topic but would it be possible to get what addons will work with v19 before installing it. On android its not possible to install both kodi versions side by side so installing v19 means we cant go back to v18 if some addons are not available.

Not even close to on topic 😉
I would recommend installing kodi somewhere else, a laptop or something and seeing if the addons you use are available on kodi 19. If not, contact the author and request a kodi 19 version.

[phunkyfish]

@AlwinEsch @enen92 this should be good now. You ok to approve?

[AlwinEsch]

Yes looks good now 👍

[enen92]

Tested and works as expected. On the first migration the dialog is shown again with the non-compatible/disabled addons. On subsequent executions the dialog is no longer shown.
Thanks for the quick fix.