New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GL-Shaders: Remove nvidia special handling #18184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernetMenta
reviewed
Jul 18, 2020
@fritsch Seems to work. Or at least, I have more choices than previously. Can supply logs if you need them to confirm. |
Let's just merge it :-) Thanks very much. |
If someone wants a backport, please go ahead. I won't do it, cause I cannot test it - and I am a bit afraid to kill certain old IONs, which might still expose that and would suffer performance issues with the change. |
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 3, 2020
GL-Shaders: Remove nvidia special handling
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
GL-Shaders: Remove nvidia special handling
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
GL-Shaders: Remove nvidia special handling
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
GL-Shaders: Remove nvidia special handling
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
GL-Shaders: Remove nvidia special handling
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
GL-Shaders: Remove nvidia special handling
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
GL-Shaders: Remove nvidia special handling
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
GL-Shaders: Remove nvidia special handling
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
GL-Shaders: Remove nvidia special handling
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 7, 2020
GL-Shaders: Remove nvidia special handling
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 8, 2020
GL-Shaders: Remove nvidia special handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nvidia decided to not expose half, half3, half4 anymore while still
exposing __GLSL_CG_DATA_TYPES - the old performance hack (TM) won't
work anymore.
Keep the defines as else the lines to be changed would(Edit: I removed them enitrely)be way more, it does not harm.
Fixes (most likely): https://forum.kodi.tv/showthread.php?tid=355910 - but needs testing by someone with nvidia GPU