Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL-Shaders: Remove nvidia special handling #18184

Merged
merged 1 commit into from Jul 18, 2020
Merged

Conversation

fritsch
Copy link
Member

@fritsch fritsch commented Jul 18, 2020

Nvidia decided to not expose half, half3, half4 anymore while still
exposing __GLSL_CG_DATA_TYPES - the old performance hack (TM) won't
work anymore. Keep the defines as else the lines to be changed would
be way more, it does not harm.
(Edit: I removed them enitrely)

Fixes (most likely): https://forum.kodi.tv/showthread.php?tid=355910 - but needs testing by someone with nvidia GPU

@fritsch fritsch added Type: Fix non-breaking change which fixes an issue v19 Matrix labels Jul 18, 2020
@fritsch fritsch added this to the Matrix 19.0-alpha 1 milestone Jul 18, 2020
@the-black-eagle
Copy link
Contributor

@fritsch Seems to work. Or at least, I have more choices than previously. Can supply logs if you need them to confirm.

@fritsch
Copy link
Member Author

fritsch commented Jul 18, 2020

Let's just merge it :-) Thanks very much.

@fritsch fritsch merged commit b985e56 into xbmc:master Jul 18, 2020
@fritsch
Copy link
Member Author

fritsch commented Jul 18, 2020

If someone wants a backport, please go ahead. I won't do it, cause I cannot test it - and I am a bit afraid to kill certain old IONs, which might still expose that and would suffer performance issues with the change.

Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
GL-Shaders: Remove nvidia special handling
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
GL-Shaders: Remove nvidia special handling
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
GL-Shaders: Remove nvidia special handling
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
GL-Shaders: Remove nvidia special handling
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
GL-Shaders: Remove nvidia special handling
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
GL-Shaders: Remove nvidia special handling
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
GL-Shaders: Remove nvidia special handling
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
GL-Shaders: Remove nvidia special handling
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
GL-Shaders: Remove nvidia special handling
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
GL-Shaders: Remove nvidia special handling
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 8, 2020
GL-Shaders: Remove nvidia special handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants