Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUIDialogSelect - add optional 3rd button #18235

Merged
merged 1 commit into from Aug 5, 2020

Conversation

DaveTBlake
Copy link
Member

@DaveTBlake DaveTBlake commented Jul 31, 2020

Add an optional 3rd button to the standard select dialog GUIDialogSelect
Update Estuary and Estouchy skins to be able to show this button (id=8)

An example use is in UI for entering multi-value settings where the user can either pick from a default list or add a new value, but other uses may arise in future.

GUIDialogSelect with 3 buttons
See #18173 where it will be used for the artist and album art whitelist settings that offer multiple selection of art types, enabling the user to add own new art types. Similar applies to video art.

Other skins will need to be modified similarly, not sure where that needs to be documented or how best to notify skinners. @ronie perhaps you can advise.

@ronie
Copy link
Member

ronie commented Jul 31, 2020

Other skins will need to be modified similarly, not sure where that needs to be documented or how best to notify skinners

i will post a heads-up in the skin changes thread on the forum,
as well as updating the wiki (https://kodi.wiki/view/List_of_Built_In_Controls#DialogSelect.xml)

could you perhaps cherry-pick ronie@5f4435a
which adds this additional button to the Estouchy skin as well.

@DaveTBlake
Copy link
Member Author

Button added to the Estouchy skin as well @ronie

Copy link
Member

@AlwinEsch AlwinEsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, so them can do some extra works via a button about.

Update both Estuary and Estouchy skins to show this button (id=8)
@DaveTBlake DaveTBlake merged commit da34f16 into xbmc:master Aug 5, 2020
@DaveTBlake DaveTBlake deleted the 3rdButton branch August 5, 2020 06:20
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 8, 2020
GUIDialogSelect - add optional 3rd button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GUI engine Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants