Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Fix grid container model access with invalid index in CGUIEPGGridContainer::GetDescription(). #18258

Merged
merged 1 commit into from Aug 8, 2020

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Aug 7, 2020

Fixes #18256

Runtime tested on macOS, latest Kodi master + pvr.demo.

@phunkyfish mind looking at the code change?

@ronie , @howie-f fyi

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: PVR v19 Matrix labels Aug 7, 2020
@ksooo ksooo added this to the Matrix 19.0-alpha 2 milestone Aug 7, 2020
@ksooo ksooo requested a review from phunkyfish August 7, 2020 18:35
Copy link
Contributor

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, thanks for the quick fix.

@howie-f
Copy link
Contributor

howie-f commented Aug 7, 2020

that was really quick, thanks a lot

@ronie
Copy link
Member

ronie commented Aug 8, 2020

thx, can confirm the crash is fixed now.

@ksooo
Copy link
Member Author

ksooo commented Aug 8, 2020

WIN-32 Jenkins error is unrelated.

@ksooo ksooo merged commit 1b4b54e into xbmc:master Aug 8, 2020
@ksooo ksooo deleted the fix-issue-18256 branch August 8, 2020 11:47
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 10, 2020
[PVR] Fix grid container model access with invalid index in CGUIEPGGridContainer::GetDescription().
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 13, 2020
[PVR] Fix grid container model access with invalid index in CGUIEPGGridContainer::GetDescription().
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 13, 2020
[PVR] Fix grid container model access with invalid index in CGUIEPGGridContainer::GetDescription().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening EPG (pvr.hts) with *assumed* faulty skin crashes matrix
4 participants