[addons] fix: allow system dependencies for repositories #18366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phunkyfish
added
Component: Add-ons
v19 Matrix
Type: Fix
phunkyfish
requested changes
Sep 3, 2020
|
jenkins build this please |
|
Jenkins build this please |
|
Thanks. AFAIK it is not unusual to have a system addon dependency in a repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
preventing installation of addon-repositories with any dependency defined is way too restrictive.
this pr allows system-addons defined in addon-manifest.xml as dependencies for repositories.
refs:
PR #18341
https://forum.kodi.tv/showthread.php?tid=356844
How Has This Been Tested?
local installation @pkscout 's Addon Beta-Channel repo which imports "xbmc.python"
Types of change
Checklist: