Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Estuary] fix navigation in skinsettings #18462

Merged
merged 1 commit into from Oct 1, 2020
Merged

Conversation

ronie
Copy link
Member

@ronie ronie commented Sep 26, 2020

Description

this fixes a navigation issue in Skin Settings > Main menu items
when navigating back from the scrollbar to the options grouplist would focus the wrong item.

this fixes the problem by pointing onleft/onright to the actual grouplist, instead of the parent group.

Motivation and Context

bug report on the forum https://forum.kodi.tv/showthread.php?tid=262373&pid=2978180#pid2978180

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@ronie ronie added Type: Fix non-breaking change which fixes an issue Component: Skin v19 Matrix labels Sep 26, 2020
@ronie ronie added this to the Matrix 19.0-alpha 2 milestone Sep 26, 2020
@ronie ronie merged commit d51f8ed into xbmc:master Oct 1, 2020
@ronie ronie deleted the estuary-navfix branch July 31, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Skin Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant