New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[curl] only use HTTP2 with SSL #18577
Conversation
Cloudflare decided in it's infinite wisdom not to follow standards that allow HTTP2 requests without encryption.
I will try iOS, tvOS and macOS. |
The Gismeteo issue remains on macOS with the current Jenkins build. Edit: As yol says, this error seems to be addon related and different from what this PR fix. |
Can say that this worked for me on Linux (Ubuntu Mate 20.04) |
@wsnipex : Obviously there's the risk of regressions with this. An alternative could be first trying plain HTTP2 and if it fails HTTP2 with TLS (or perhaps the other way around is better anyway?). But maybe we should just see how your PR works out and keep this in mind in case issues surface. |
Tested with HDHomeRun guide (without this fix TV guide is empty):
|
@arnova I don't see a real risk, since that setting is the curl default and behaves like all modern browsers |
Is there a build for this somewhere? I would like the member using FreeBSD to test this out... |
Ah yes, that's right ofc. Then I think we're good :-) |
@KarellenX we don't provide freebsd builds, he would have to compile himself. |
Description
Cloudflare decided in it's infinite wisdom not to follow standards
that allow HTTP2 requests without encryption.
This changes curl to only use HTTP2 with SSL.
Motivation and Context
Numerous reports of TMDB scrapers failing, IPTV issues..
How Has This Been Tested?
not yet. Please test on all platforms but windows, which is not affected
Screenshots (if appropriate):
Types of change
Checklist: