Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAAPI: fix logging by removing trailing characters #18617

Merged
merged 1 commit into from Oct 22, 2020
Merged

VAAPI: fix logging by removing trailing characters #18617

merged 1 commit into from Oct 22, 2020

Conversation

lrusak
Copy link
Contributor

@lrusak lrusak commented Oct 21, 2020

This fixes an issue where vaapi messages seem to print with a newline character at the end.

before:

2020-10-19 09:53:25.708 T:2326007   DEBUG <general>: libva info: VA-API version 1.7.0

2020-10-19 09:53:25.708 T:2326007   DEBUG <general>: libva info: Trying to open /usr/lib64/dri/radeonsi_drv_video.so

2020-10-19 09:53:25.708 T:2326007   DEBUG <general>: libva info: Found init function __vaDriverInit_1_7

2020-10-19 09:53:25.716 T:2326007   DEBUG <general>: libva info: va_openDriver() returns 0

2020-10-19 09:53:25.716 T:2326007   DEBUG <general>: VAAPI - initialize version 1.7

after:

2020-10-21 12:02:24.035 T:2521357   DEBUG <general>: libva info: VA-API version 1.7.0
2020-10-21 12:02:24.035 T:2521357   DEBUG <general>: libva info: Trying to open /usr/lib64/dri/radeonsi_drv_video.so
2020-10-21 12:02:24.035 T:2521357   DEBUG <general>: libva info: Found init function __vaDriverInit_1_7
2020-10-21 12:02:24.040 T:2521357   DEBUG <general>: libva info: va_openDriver() returns 0
2020-10-21 12:02:24.040 T:2521357   DEBUG <general>: VAAPI - initialize version 1.7

@lrusak lrusak added Type: Improvement non-breaking change which improves existing functionality Platform: Linux v19 Matrix Component: Logging labels Oct 21, 2020
@lrusak lrusak added this to the Matrix 19.0-alpha 3 milestone Oct 21, 2020
@lrusak lrusak requested review from fritsch and yol October 21, 2020 19:10
garbear
garbear approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@garbear garbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the signature of StringUtils::TrimRight() and it looks right.

@fuzzard fuzzard merged commit abce33c into xbmc:master Oct 22, 2020
@lrusak lrusak deleted the vaapi-logging branch February 11, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbear garbear garbear approved these changes

@fritsch fritsch fritsch approved these changes

@yol yol yol approved these changes

Assignees
No one assigned
Labels
Component: Logging Platform: Linux Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-alpha 3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lrusak @garbear @fritsch @yol @fuzzard