Make musicvideosallperformers setting default "true"

[scott967]

Description

Change the default for setting "musicvideosallperformers" to "true"

Motivation and Context

In Kodi versions 18 and prior, the behavior for musicvideo library "artists" node is to display all artists (actors) related to musicvideo items in the video db.

Kodi 19 PR#18386 adds a new setting that toggles display of "all performers" or "main performers". The current default for the setting is false, so only "main performers" are displayed. As a result a user upgrading an existing Kodi client to v19 will have a changed experience when viewing musicvideo artists. If the user is unaware of the new setting, it appears that artists are "missing" from the view. This PR will result in users seeing the same artists as in prior versions by default.

How Has This Been Tested?

installed Kodi 18.9 Win x64 from exe nullsoft installer as a portable install on Win 10 2004.. Added a musicvideo source and scanned to library. Opened musicvideo artist library node and observed 1461 artists in listing.

installed Kodi 19 B3 from exe nullsoft installer on top of 18.9. Opened musicvideo artist library node and observed 258 artists.

Repeated, but replaced system\settings\settings.xml with updated version prior to first execution of kodi after upgrade to Kodi 19 B3. Opened musicvideo artist library node and observed 1461 artists.

Note: Wiki for settings/video/media has not been updated in "Changes in Kodi 19 Matrix" to show this new setting.

Screenshots (if appropriate):

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[the-black-eagle]

Although this is highly dependent on how you have added your artists (scraper will just add an <artist> tag afaik, whereas this enables showing artists/performers that have been added via an <actor> tag in an nfo file) I guess that enabling a new feature is a good idea. Users can always turn it off if they don't like it to revert to the original behaviour.
Therefore, +1 from me.